Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove humps dependency #57

Merged
merged 2 commits into from
Feb 24, 2022
Merged

Remove humps dependency #57

merged 2 commits into from
Feb 24, 2022

Conversation

plutopulp
Copy link
Contributor

@plutopulp plutopulp commented Feb 24, 2022

The humps package provides the same module as the pyhumps package. We want the latter but the dependencies specify both for some reason.

This PR removes humps, which removes possible ambiguities when importing humps.

@plutopulp plutopulp requested a review from a team as a code owner February 24, 2022 11:50
@alexpearce
Copy link
Contributor

Just a heads-up that poetry lock will try to update all packages within the constraints specified in the pyproject.toml, which is why there are unrelated changes in the lockfile. You can use poetry lock --no-update to avoid this (although it's typically no big deal).

@alexpearce alexpearce force-pushed the plutopulp/remove-humps branch from c90ccb2 to ebb5a5f Compare February 24, 2022 12:00
Copy link
Contributor

@alexpearce alexpearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexpearce alexpearce changed the title Plutopulp/remove humps Remove humps dependency Feb 24, 2022
@alexpearce alexpearce enabled auto-merge (squash) February 24, 2022 12:01
@alexpearce alexpearce merged commit 84198d0 into main Feb 24, 2022
@alexpearce alexpearce deleted the plutopulp/remove-humps branch February 24, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants