Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create brief schema, keep pipelineGet as is #78

Merged
merged 4 commits into from
Apr 20, 2022

Conversation

bjornaer
Copy link
Contributor

@bjornaer bjornaer commented Apr 14, 2022

This PR aims to create a Brief schema for PipelineGet which holds the most basic information for pipelines, this approach was preferred to preserve PipelineGet schema with its original fields, thus avoiding possible unforeseen impact on other services.

@bjornaer bjornaer self-assigned this Apr 14, 2022
@bjornaer bjornaer requested a review from a team as a code owner April 14, 2022 14:03
@bjornaer bjornaer requested a review from isNeil April 14, 2022 14:03
Copy link
Contributor

@adamleithp-mystic adamleithp-mystic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@plutopulp plutopulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff man! LGTM

@plutopulp plutopulp self-requested a review April 14, 2022 14:17
plutopulp
plutopulp previously approved these changes Apr 14, 2022
isNeil
isNeil previously approved these changes Apr 20, 2022
Copy link
Contributor

@isNeil isNeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bjornaer bjornaer dismissed stale reviews from isNeil and plutopulp via 7e40301 April 20, 2022 10:19
Copy link
Contributor

@isNeil isNeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bjornaer bjornaer merged commit 0483d90 into main Apr 20, 2022
@bjornaer bjornaer deleted the max/change-pipeline-get-schema branch April 20, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants