Fix: no-deprecated-api crash on undeclared assignment (fixes #55) (#56

)
mysticatea · Nov 1, 2016 · 610b905 · 610b905
1 parent 382886e
commit 610b905
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/lib/rules/no-deprecated-api.js b/lib/rules/no-deprecated-api.js
@@ -246,11 +246,10 @@ module.exports = function(context) {
                 break
 
             case "Identifier":
-                checkVariable(
-                    findVariable(node, globalScope),
-                    path,
-                    infoMap
-                )
+                var variable = findVariable(node, globalScope)
+                if (variable != null) {
+                    checkVariable(variable, path, infoMap)
+                }
                 break
 
             case "ObjectPattern":

diff --git a/tests/lib/rules/no-deprecated-api.js b/tests/lib/rules/no-deprecated-api.js
@@ -86,6 +86,12 @@ ruleTester.run("no-deprecated-api", rule, {
             code: "import domain from 'domain';",
             parserOptions: {sourceType: "module"},
         },
+
+        // https://github.com/mysticatea/eslint-plugin-node/issues/55
+        {
+            code: "undefinedVar = require('fs')",
+            env: {node: true},
+        },
     ],
     invalid: [
         //----------------------------------------------------------------------