Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule no-missing-require is broken with 4.2.0 #70

Closed
mathieug opened this issue Mar 13, 2017 · 13 comments · Fixed by singapore/lint-condo#246
Closed

rule no-missing-require is broken with 4.2.0 #70

mathieug opened this issue Mar 13, 2017 · 13 comments · Fixed by singapore/lint-condo#246

Comments

@mathieug
Copy link

Since the update from 4.1.0 to 4.2.0, rule no-missing-require is broken for paths like '../../somefile'

@mathieug mathieug changed the title [4.2.0] rule no-missing-require is broken rule no-missing-require is broken with 4.2.0 Mar 13, 2017
@saikojosh
Copy link

I've noticed the same issue. Super annoying! The path definitely exists but I'm told it's incorrect. 😕

@mysticatea
Copy link
Owner

Thank you for this report, and I'm sorry.
I'll investigate it.

@mysticatea
Copy link
Owner

mysticatea commented Mar 14, 2017

To make sure, which is the "broken" meaning false positive or negative?
I could not reproduce it.
Please note the no-missing-require rule has checked files with case sensitive since v4.2.0: release note

@mathieug
Copy link
Author

Broken means the file exist but I have this error: Error - "../../../libs/co-route" is not found. (node/no-missing-require)

@mysticatea
Copy link
Owner

mysticatea commented Mar 14, 2017

Hmm, I could not reproduce it.
Could you give me whole repro steps or repository?

@mathieug
Copy link
Author

mathieug commented Mar 14, 2017

Can you try on SublimeText with those addons installed: SublimeLinter, SublimeLinter-eslint ?

@mathieug
Copy link
Author

mathieug commented Mar 14, 2017

Create two files:
/test1/a.js = module.exports = {};
/test2/b.js = require('../test1/a');

You need to install eslint and eslint-plugin-node with npm, then configure .eslintrc with eslint-plugin-node and the rule node/no-missing-require.

@mysticatea
Copy link
Owner

OK, I reproduced it on Sublime Text. Thank you!

@mathieug
Copy link
Author

Thank you!

@mathieug
Copy link
Author

mathieug commented Mar 14, 2017

Amazing, thanks @mysticatea
Are you going to release a v4.2.1?

@mysticatea
Copy link
Owner

I released v4.2.1. I'm sorry for this annoying.

@mathieug
Copy link
Author

Don't be.
I've tested and it works, thanks for your work and your great reactivity.

@saikojosh
Copy link

Thanks guys this works perfectly now! 😆 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants