This repository has been archived by the owner on Oct 8, 2019. It is now read-only.
Support Hellinger-distance-based scoring both on SDAR 1D and 2D #330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR includes
By keeping the last
_mu
and_sigma
in the SDAR algorithm as_muOld
and_sigmaOld
, we are now able to compute the Hellinger distance between the models before/after update. Usage is demonstrated as comments in ChangeFinder1D and ChangeFinder2D.Computation of the Hellinger distance between two (multivariate) normal distributions are implemented on MathUtils.
Are the Hellinger distances computed correctly?
Unit tests have not been implemented yet. However, I have confirmed whether it works as expected by comparing the results of Python implementation.
For the above parameters, the Python code returns a distance 0.0661275442145.
Here, our
MathUtils.hellingerDistanes()
method also works as: