Fixing isArrayLike to allow length as a param. Added test #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mzabriskie any thoughts on this? Also when do you see the next version being released? |
mzabriskie
added a commit
that referenced
this pull request
Jul 23, 2015
Fixing isArrayLike to allow length as a param. Added test
|
Thanks for the PR. I am hoping to get a release in the next few weeks. I'm swamped with a few other projects right now, so just trying to keep all the balls in the air as it were. |
|
No worries. Thanks for the update :) |
|
I just released 0.6.0 which includes your PR. |
|
Awesome. Thanks for the heads up |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using length as a test for whether an Object is "Array-like" produces unexpected results.
There may be more objects that need specific checks (other than object Arguments). But this passes all existing tests and the new one.