feat: Remove endpoint from protocol constructor. #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was only needed for creating tickets, which is used almost nowhere. If you want to create a BlobTicket, just do it manually.
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-blobs/pr/181/docs/iroh_blobs/ Last updated: 2025-10-08T14:34:00Z |
dignifiedquire
approved these changes
Oct 8, 2025
|
nice improvement |
rklaehn
changed the title
- rand update - .initialized().await removal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove endpoint from protocol constructor.
It was only needed for creating tickets, which is used almost nowhere. To serve a protocol you just need the store, nothing else.
If you want to create a BlobTicket, just do it manually.
Breaking Changes
BlobsProtocol::new now takes just store and events
BlobsProtocol::endpoint is removed
BlobsProtocol::ticket is removed
api::TempTag::inner is removed
api::TempTag::hash returns a value instead of a reference
api::TempTag::format returns a value instead of a reference
api::TempTag::hash_and_format returns a value instead of a reference
Notes & open questions
None
Change checklist