Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(derp): Default DNS name rooted at the DNS root #1231

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

flub
Copy link
Contributor

@flub flub commented Jul 13, 2023

Description

This makes sure that the default DNS name starts at the DNS root so
that DNS resolvers do not start searching their search domains.

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates if relevant.
  • Tests if relevant.

This makes sure that the default DNS name starts at the DNS root so
that DNS resolvers do not start searching their search domains.
@flub flub enabled auto-merge (squash) July 13, 2023 15:50
@dignifiedquire
Copy link
Contributor

dignifiedquire commented Jul 13, 2023

Does this work in all cases? we also do http requests to this URL

@flub
Copy link
Contributor Author

flub commented Jul 14, 2023

Yes, that works. HTTP just does DNS under the hood like anyone else. Also, tests pass :)

@divagant-martian
Copy link
Contributor

divagant-martian commented Jul 14, 2023

this means the constant can be used in at least one more place I think: ah it's not exactly the same, this is what I had in mind

let stun_servers = vec![("https://derp.iroh.network.", DEFAULT_DERP_STUN_PORT)];

@dignifiedquire
Copy link
Contributor

@flub merge conflicts

@flub flub merged commit 8116345 into main Jul 17, 2023
@flub flub deleted the flub/derp-default-dns-root branch July 17, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants