Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*): log me #1561

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Conversation

divagant-martian
Copy link
Contributor

@divagant-martian divagant-martian commented Oct 2, 2023

Description

second take at #1544 since forced pushed closed prs can't be reopened

Magicsock

2023-10-02T18:46:34.455601Z DEBUG magicsock{me=2luekswh7o3a5tz4}:derp.actor:recv_detail:client-connect{key=2luekswh7o3a5tz4enymovsoksgnpb2qpmxlvifp6ywwjnacihya}:connect_0: rustls::client::tls13: TLS1.3 encrypted extensions: [ServerNameAck]

Sync

2023-09-28T20:51:18.908126Z DEBUG sync{me=oywqb57ovmdry243}: iroh::sync_engine::live: sync[dial]: start namespace=NamespaceId(q47zmyim5r6isz22…) peer=PublicKey(2jnygwapdm26wwa2) reason=DirectJoin last_state=None

Gossip

2023-09-28T20:58:42.854730Z DEBUG gossip{me=zooj7iazcl7rsoal}: iroh_gossip::net: handle out_event EmitEvent(TopicId(wno5nwxtkhhtnqsm…), Received(GossipEvent { content: <33b>, delivered_from: PublicKey(7a7kkzndvbt6eulu), scope: Neighbors }))

Downloader

2023-09-28T21:00:11.107411Z DEBUG downloader{me=4vabufwku3wselbl}: iroh::downloader: download completed peer=2jnygwapdm26wwa26tvcprm3m5vqajmhwz7lx5xizwx637ad5sea kind=Blob { hash: Hash(224746ea89d286220e0770f89cda2ab138143b00e384dd795d5a13b77b094822) }

Notes & open questions

probably we will add this in other places or change the logging level but would be good to get this in to at least have something over which we can iterate

Change checklist

  • Self-review.
  • Documentation updates if relevant.
  • Tests if relevant.

flub
flub previously approved these changes Oct 2, 2023
@divagant-martian
Copy link
Contributor Author

@flub saw that you approved, you sure you are happy with this? happy to receive further feedback

@divagant-martian divagant-martian dismissed flub’s stale review October 2, 2023 18:48

new module has been added

@divagant-martian divagant-martian added this pull request to the merge queue Oct 2, 2023
Merged via the queue into n0-computer:main with commit 7e79227 Oct 2, 2023
15 checks passed
@divagant-martian divagant-martian deleted the log_self branch October 2, 2023 23:22
@flub
Copy link
Contributor

flub commented Oct 3, 2023

@flub saw that you approved, you sure you are happy with this? happy to receive further feedback

yes, I think this looks fine and is as was discussed :)

@b5 b5 added this to the v0.7.0 milestone Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants