feat(iroh-net): extend discovery NodeInfo to allow direct addrs #2201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unused for now, just to have the option
rklaehn
force-pushed
the
extend-node-info
branch
from
86e12a1
to
517f4cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat(iroh-net): extend discovery NodeInfo to allow direct addrs
This should be compatible with what is sketched in #2149
For now we leave the direct addresses empty, but having this would allow tools like https://github.com/n0-computer/iroh-examples/tree/main/iroh-pkarr-node-discovery to publish everything (optionally) without having to reimplement the conversion from/to signed packets.
Notes & open questions
Change checklist