-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): add metrics server to iroh doctor #2292
Conversation
Maybe I'm doing something wrong but it seems to me this conflicts with Conversely, if I start |
I think my expectations are:
So maybe something like:
|
## Description Folks try to look at metrics while doctor alone is running (note this clashes by default with the iroh node if both are running locally on port :9090). Also kind of inconvenient given if you want to look at a running iroh node when doctor is running. Suggestions welcome, maybe default off metrics on `doctor`? Also most metrics are not really used in the `doctor` path, but we can fix that as we figure out what's cool to measure. ## Breaking Changes <!-- Optional, if there are any breaking changes document them, including how to migrate older code. --> ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [x] Self-review. - [ ] Documentation updates if relevant. - [ ] Tests if relevant. - [ ] All breaking changes documented.
This should now work decently nice for the above use cases. Metrics are off by default and you can turn them on when you like by setting the metrics port.
|
Description
Folks try to look at metrics while doctor alone is running (note this clashes by default with the iroh node if both are running locally on port :9090). Also kind of inconvenient given if you want to look at a running iroh node when doctor is running.
Suggestions welcome, maybe default off metrics on
doctor
?Also most metrics are not really used in the
doctor
path, but we can fix that as we figure out what's cool to measure.Breaking Changes
Notes & open questions
Change checklist