Remove dumping packet content in Debug... #988
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dMessage::ReceivedPacket This prevents seeing a giant wall of useless text when running with debug tracing. If we actually need the package contents we can do something more fancy like a hex dump of the first n chars, but I think this is already useful.
|
We will wait some time for a new derive_more release JelteF/derive_more#259 that includes custom debug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...for DerpReadResult and ReceivedMessage::ReceivedPacket
This prevents seeing a giant wall of useless text when running with debug tracing. If we actually need the package contents we can do something more fancy like a hex dump of the first n chars, but I think this is already useful.