Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovate/major sentry javascript monorepo #2277

Merged

Conversation

trixobird
Copy link
Contributor

@trixobird trixobird commented Aug 4, 2024

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of
the pull request.

Description

This PR makes the sentry plugin compatible with Sentry v8 SDK.

Fixes # (2193)

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)

How Has This Been Tested?

Have not written any new tests, have not modified any existing tests.

  • sentry.spec.ts

Test Environment:

  • OS: MacOS 14.5 Sonoma
  • @envelop/sentry:
  • NodeJS:

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

Resources:

Copy link

changeset-bot bot commented Aug 4, 2024

🦋 Changeset detected

Latest commit: 7f3f386

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@envelop/immediate-introspection Major
@envelop/sentry Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gajus
Copy link

gajus commented Aug 5, 2024

Wonderful!

@gajus
Copy link

gajus commented Aug 19, 2024

@dotansimha Any chance of getting this across the line?

@gajus
Copy link

gajus commented Aug 25, 2024

@n1ru4l Anything missing to merge this?

@Boeing787
Copy link

Hey folks @n1ru4l @dotansimha -- would love to see @trixobird 's work get merged here! Looks like it is passing all tests and would unblock us from adopting V8 tracing 🙏 Let me know if you need any support with that 👍

@FezVrasta
Copy link

FezVrasta commented Sep 3, 2024

Really looking forward to this. Could you guys prioritize this PR please?

edit: for now I published this as a fork on @fezvrasta/envelop-sentry.

@@ -48,7 +48,7 @@
"typings": "dist/typings/index.d.ts",
"peerDependencies": {
"@envelop/core": "^5.0.0",
"@sentry/node": "^6 || ^7",
"@sentry/node": "^8.0.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this change be considered breaking as v6 and v7 is not supported anymore?

@@ -0,0 +1,8 @@
---
'@envelop/sentry': patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'@envelop/sentry': patch
'@envelop/sentry': major

Copy link
Collaborator

@enisdenjo enisdenjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me (after applying this suggestion). Please rebase so that we can go ahead and merge this.

@trixobird trixobird force-pushed the renovate/major-sentry-javascript-monorepo branch from 28d165d to 890e7ec Compare October 2, 2024 13:44
@trixobird
Copy link
Contributor Author

@enisdenjo rebased and changed the changeset. Let me know if there is anythig else that I can do at this point.

@@ -0,0 +1,8 @@
---
'@envelop/immediate-introspection': patch
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'@envelop/immediate-introspection': patch
'@envelop/immediate-introspection': major

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @enisdenjo, let me know if there is anythig else that I can do at this point.

@enisdenjo enisdenjo merged commit 9f65fcb into n1ru4l:main Oct 4, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants