-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renovate/major sentry javascript monorepo #2277
Renovate/major sentry javascript monorepo #2277
Conversation
🦋 Changeset detectedLatest commit: 7f3f386 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Wonderful! |
@dotansimha Any chance of getting this across the line? |
@n1ru4l Anything missing to merge this? |
Hey folks @n1ru4l @dotansimha -- would love to see @trixobird 's work get merged here! Looks like it is passing all tests and would unblock us from adopting V8 tracing 🙏 Let me know if you need any support with that 👍 |
Really looking forward to this. Could you guys prioritize this PR please? edit: for now I published this as a fork on |
@@ -48,7 +48,7 @@ | |||
"typings": "dist/typings/index.d.ts", | |||
"peerDependencies": { | |||
"@envelop/core": "^5.0.0", | |||
"@sentry/node": "^6 || ^7", | |||
"@sentry/node": "^8.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this change be considered breaking as v6 and v7 is not supported anymore?
@@ -0,0 +1,8 @@ | |||
--- | |||
'@envelop/sentry': patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'@envelop/sentry': patch | |
'@envelop/sentry': major |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me (after applying this suggestion). Please rebase so that we can go ahead and merge this.
28d165d
to
890e7ec
Compare
@enisdenjo rebased and changed the changeset. Let me know if there is anythig else that I can do at this point. |
@@ -0,0 +1,8 @@ | |||
--- | |||
'@envelop/immediate-introspection': patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'@envelop/immediate-introspection': patch | |
'@envelop/immediate-introspection': major |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @enisdenjo, let me know if there is anythig else that I can do at this point.
🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of
the pull request.
Description
This PR makes the sentry plugin compatible with Sentry v8 SDK.
Fixes # (2193)
Type of change
expected)
How Has This Been Tested?
Have not written any new tests, have not modified any existing tests.
sentry.spec.ts
Test Environment:
@envelop/sentry
:Checklist:
CONTRIBUTING doc and the
style guidelines of this project
Further comments
Resources: