Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add manual login option and password reset link for SSO #6328

Conversation

flipswitchingmonkey
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Files matching packages/design-system/**/*.vue:

  • Used design system tokens (colors, spacings...) where possible.
  • Updated Storybook with new component or updated functionality.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch coverage: 21.42% and project coverage change: -0.02 ⚠️

Comparison is base (b777f90) 27.66% compared to head (6f3df89) 27.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6328      +/-   ##
==========================================
- Coverage   27.66%   27.65%   -0.02%     
==========================================
  Files        2958     2958              
  Lines      181357   181490     +133     
  Branches    19724    19727       +3     
==========================================
+ Hits        50179    50196      +17     
- Misses     130433   130548     +115     
- Partials      745      746       +1     
Impacted Files Coverage Δ
packages/cli/src/controllers/auth.controller.ts 76.19% <0.00%> (ø)
packages/cli/src/databases/entities/User.ts 93.10% <ø> (ø)
...ign-system/src/components/N8nUserInfo/UserInfo.vue 0.00% <0.00%> (ø)
...n-system/src/components/N8nUsersList/UsersList.vue 0.00% <0.00%> (ø)
packages/workflow/src/Interfaces.ts 50.00% <ø> (ø)
packages/editor-ui/src/views/SettingsUsersView.vue 47.79% <6.89%> (-12.42%) ⬇️
packages/editor-ui/src/api/users.ts 23.35% <12.50%> (-0.99%) ⬇️
packages/editor-ui/src/stores/users.store.ts 44.60% <21.05%> (-1.39%) ⬇️
packages/cli/src/controllers/users.controller.ts 75.11% <25.00%> (-4.37%) ⬇️
...es/cli/src/controllers/passwordReset.controller.ts 85.71% <100.00%> (+0.32%) ⬆️
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels May 26, 2023
@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@flipswitchingmonkey flipswitchingmonkey merged commit 77e3f15 into master May 30, 2023
21 of 22 checks passed
@flipswitchingmonkey flipswitchingmonkey deleted the pay-457-add-a-feature-to-allow-some-people-to-log-without-sso branch May 30, 2023 10:52
MiloradFilipovic added a commit that referenced this pull request Jun 1, 2023
* master: (54 commits)
  feat: Version control mvp (#6271)
  feat(editor): Implement Resource Mapper component (#6207)
  fix(editor): Update SSO settings styles (#6342)
  fix: Show `Ask AI` only on Code Node (#6336)
  feat(core): Add metadata (customdata) to event log (#6334)
  refactor: Add telemetry to upgrade paths (no-changelog) (#6313)
  fix(Code Node): Fix `item` and `items` alias regression (#6331)
  feat: Add manual login option and password reset link for SSO (#6328)
  fix(editor): Fix Luxon date parsing of ExecutionsUsage component (#6333)
  fix(core): Do not track errored workflow executions for automated executions (no-changelog) (#6322)
  fix(core): Prevent prototype pollution on injectable services (#6309)
  fix(core): Optimize getSharedWorkflowIds query (#6314)
  ci: Reset DB only once per e2e test (no-changelog) (#6216)
  feat(editor): Bring back checklist experiment (no-changelog) (#6307)
  fix: Add ldapts to nodes-base package (no-changelog) (#6315)
  fix(Code Node): Update vm2 to address CVE-2023-32313 (#6318)
  feat: Add tab visibility change detection when polling executions (no-changelog) (#6311)
  fix(editor): Fix locale plularisation if count is 0 (#6312)
  🚀 Release 0.230.0 (#6310)
  fix(Execute Command Node): Block executions when `command` is empty (#6308)
  ...
@janober
Copy link
Member

janober commented Jun 5, 2023

Got released with n8n@0.231.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants