Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Ldap Node): Add DN field to update operation #6371

Merged
merged 2 commits into from
Jun 7, 2023
Merged

fix(Ldap Node): Add DN field to update operation #6371

merged 2 commits into from
Jun 7, 2023

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Jun 2, 2023

Github issue / Community forum post (link here to close automatically): #6369

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Jun 2, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.09 ⚠️

Comparison is base (3a6af3b) 28.34% compared to head (6e87a01) 28.25%.

❗ Current head 6e87a01 differs from pull request most recent head 0939e69. Consider uploading reports for the commit 0939e69 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6371      +/-   ##
==========================================
- Coverage   28.34%   28.25%   -0.09%     
==========================================
  Files        2980     2982       +2     
  Lines      185006   185187     +181     
  Branches    20308    20302       -6     
==========================================
- Hits        52447    52333     -114     
- Misses     131772   132067     +295     
  Partials      787      787
Impacted Files Coverage Δ
packages/nodes-base/nodes/Ldap/LdapDescription.ts 0.00% <ø> (ø)

... and 80 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress
Copy link

cypress bot commented Jun 6, 2023 •
edited
Loading

Passing run #1132 ↗︎

0 227 0 0 Flakiness 0

Details:

🌳 add-dn-to-update 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Project: n8n Commit: 0939e696ea
Status: Passed Duration: 07:49 💡
Started: Jun 7, 2023 9:00 AM Ended: Jun 7, 2023 9:08 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Jun 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@maspio maspio self-requested a review June 7, 2023 07:41
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

✅ All Cypress E2E specs passed

@Joffcom Joffcom merged commit 9396e7e into master Jun 7, 2023
@Joffcom Joffcom deleted the add-dn-to-update branch June 7, 2023 09:31
MiloradFilipovic added a commit that referenced this pull request Jun 13, 2023
@MiloradFilipovic
Merge branch 'master' into sql-editor-support-expressions
bad65fb 
* master:
  test(editor): Unit test Version control frontend components (#6408)
  fix: Fist name to First Name in certain nodes (no-changelog) (#6404)
  fix(core): Allow all executions to be stopped (#6386)
  fix(core): RMC boolean value fix (#6397)
  fix(editor): Remove root level tag selector from css module to avoid making it a global style (#6392)
  fix(Ldap Node): Add DN field to update operation (#6371)
  feat: New trigger PostgreSQL  (#5495)
  build: Update pnpm lock file (no-changelog) (#6395)
  fix(Date & Time Node): Reset responseData at end of loop (#6385)
  refactor(core): Google service account remove duplicated functions (no-changelog) (#6368)
  refactor(LoneScale List Node)!: Rename to LoneScale (#6337)
  fix(editor): Update version control setup CTA tooltip (#6393)
  ci: Fix build (no-changelog) (#6391)
  fix(editor): Add button to refresh branches (#6387)
  fix(editor): Add Set up version control CTA (#6356)
  fix(editor): Remove explicit parameter name scanning for code editors (#6390)
  ci: Fix build (no-changelog) (#6379)
  fix(editor): Adding branch color (#6380)
  refactor(editor): Remove user activation modal (no-changelog) (#6361)
  feat(editor): Change upgrade CTA on community editions (no-changelog) (#6317)
@janober
Copy link
Member

janober commented Jun 14, 2023

Got released with n8n@0.232.0

netroy pushed a commit that referenced this pull request Jun 14, 2023
@Joffcom @netroy
fix(Ldap Node): Add DN field to update operation (#6371)
43d660c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maspio maspio maspio approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Joffcom @janober @maspio