Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(editor): Add color selector to sticky node #7453

Merged
merged 20 commits into from
Nov 8, 2023
Merged

feat(editor): Add color selector to sticky node #7453

merged 20 commits into from
Nov 8, 2023

Conversation

RicardoE105
Copy link
Contributor

@RicardoE105 RicardoE105 commented Oct 17, 2023 •
edited
Loading

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023 •
edited
Loading

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Files matching packages/design-system/**/*.vue:

  • Used design system tokens (colors, spacings...) where possible.
  • Updated Storybook with new component or updated functionality.

Files matching cypress/e2e/**:

  • Avoided chaining commands more than two or three times (to avoid flakiness because only last one will be retried).
  • Spoofed endpoints that are not critical for the test (to avoid flakiness).
  • Picked most efficient path to start the test (for example skipped account setup and starting at /workflow/new for a canvas test).
  • Avoided adding waits on time (use request intercepts instead).
  • Ensured each spec does not depend on any another spec to pass.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request ui Enhancement in /editor-ui or /design-system labels Oct 17, 2023
mutdmour
mutdmour reviewed Oct 17, 2023
View reviewed changes
Copy link
Contributor

@mutdmour mutdmour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add tests

@codecov
Copy link

codecov bot commented Oct 17, 2023 •
edited
Loading

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (437c95e) 33.74% compared to head (8c51a0e) 32.07%.
Report is 50 commits behind head on master.

❗ Current head 8c51a0e differs from pull request most recent head b90ceca. Consider uploading reports for the commit b90ceca to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7453      +/-   ##
==========================================
- Coverage   33.74%   32.07%   -1.68%     
==========================================
  Files        3408     3410       +2     
  Lines      208583   208861     +278     
  Branches    22562    22660      +98     
==========================================
- Hits        70391    66986    -3405     
- Misses     137044   140710    +3666     
- Partials     1148     1165      +17
Files Coverage Δ
packages/editor-ui/src/plugins/icons/index.ts 100.00% <100.00%> (ø)
...ges/nodes-base/nodes/StickyNote/StickyNote.node.ts 40.00% <ø> (ø)
.../design-system/src/components/N8nSticky/Sticky.vue 82.03% <94.00%> (+2.35%) ⬆️
packages/editor-ui/src/components/Sticky.vue 65.89% <86.60%> (+7.12%) ⬆️

... and 111 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RicardoE105 RicardoE105 changed the title Add color selector to sticky node feat(editor): Add color selector to sticky node Oct 17, 2023
@StarfallProjects StarfallProjects mentioned this pull request Oct 24, 2023
Merged
mutdmour
mutdmour reviewed Oct 25, 2023
View reviewed changes
Copy link
Contributor

@mutdmour mutdmour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of small comments

cypress/e2e/25-stickies.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/25-stickies.cy.ts Outdated Show resolved Hide resolved
@cypress
Copy link

cypress bot commented Oct 30, 2023 •
edited
Loading

2 flaky tests on run #2780 ↗︎

0 264 0 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 RicardoE105 🗃️ e2e/*
Project: n8n Commit: b90ceca949
Status: Passed Duration: 08:13 💡
Started: Nov 8, 2023 1:04 PM Ended: Nov 8, 2023 1:12 PM
Flakiness  2-credentials.cy.ts • 1 flaky test

View
Output
Video

Test Artifacts
Credentials > should create a new credential using Add Credential button Screenshots Video
Flakiness  6-code-node.cy.ts • 1 flaky test

View
Output
Video

Test Artifacts
... > generate code button should have correct state & tooltips Screenshots Video

Review all test suite changes for PR #7453 ↗︎

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

✅ All Cypress E2E specs passed

@RicardoE105 RicardoE105 merged commit 8359364 into master Nov 8, 2023
53 of 54 checks passed
@RicardoE105 RicardoE105 deleted the feat/color-stitcky branch November 8, 2023 13:23
@github-actions github-actions bot mentioned this pull request Nov 15, 2023
Merged
ivov added a commit that referenced this pull request Nov 15, 2023
@github-actions @ivov
🚀 Release 1.17.0 (#7720)
93103c0 
#
[1.17.0](https://github.com/n8n-io/n8n/compare/n8n@1.16.0...n8n@1.17.0)
(2023-11-15)


### Bug Fixes

* **Convert to/from binary data Node:** Better mime type defaults
([#7693](#7693))
([9b3be0c](9b3be0c))
* **core:** Consider subworkflows successfully run when in waiting state
([#7699](#7699))
([0e00dab](0e00dab))
* **core:** Fix named parameter resolution in migrations
([#7688](#7688))
([4441ed5](4441ed5)),
closes [#7628](#7628)
* **core:** Initialize JWT Secret before it's used anywhere
([#7707](#7707))
([3460eb5](3460eb5))
* **core:** Reduce memory usage in credentials risk auditing
([#7663](#7663))
([9fd6319](9fd6319))
* **Date & Time Node:** Add fromFormat option to solve ambiguous date
strings ([#7675](#7675))
([d2d11e0](d2d11e0))
* **editor:** Fix resource mapper component being truncated
([#7664](#7664))
([00dff50](00dff50))
* **editor:** More securely clear executions tab auto refresh timer
([#7685](#7685))
([37dd658](37dd658))
* **editor:** Redirect to workflow editor after saving in debug mode
([#7645](#7645))
([020042e](020042e))
* **Google Sheets Node:** Append exceeding grid limits
([#7684](#7684))
([88efb99](88efb99))
* **HTTP Request Node:** Support generic credentials when using
pagination ([#7686](#7686))
([48b240b](48b240b)),
closes [#7653](#7653)
* **HubSpot Node:** Fetching available parameters fails when using
expressions ([#7672](#7672))
([a9ab738](a9ab738))
* **HubSpot Node:** Update deal owner on Hubspot Deal
([#7673](#7673))
([3c0734b](3c0734b))
* **Spreadsheet File Node:** Read file as utf-8 in v1
([#7701](#7701))
([786b4ad](786b4ad))


### Features

* **core:** Expression function $ifEmpty
([#7660](#7660))
([1c7225e](1c7225e))
* **Date & Time Node:** Option to include other fields in output item
([#7661](#7661))
([aea3c50](aea3c50))
* **Discord Node:** Overhaul
([#5351](#5351))
([6a53c2a](6a53c2a))
* **Discourse Node:** Add new options to Get Users
([#7674](#7674))
([2e8c841](2e8c841))
* **editor:** Add color selector to sticky node
([#7453](#7453))
([8359364](8359364))
* **editor:** Add HTTP request nodes for credentials without a node
([#7157](#7157))
([14035e1](14035e1))
* **editor:** Add workflow filters to querystring
([#7456](#7456))
([afd637b](afd637b))
* **editor:** Adds a EE view to show worker details and job status
([#7600](#7600))
([cbc6909](cbc6909))
* **GitLab Node:** Add support for pagination on getIssues
([#7529](#7529))
([0a0798e](0a0798e))
* **OpenAI Node:** Add dall-e-3 support
([#7655](#7655))
([a9c7188](a9c7188))
* **RabbitMQ Trigger Node:** Add exchange and routing key options
([#7547](#7547))
([5aee2b7](5aee2b7))
* **Telegram Node:** Add support for markdownv2
([#7679](#7679))
([819b3a7](819b3a7))
* **Venafi TLS Protect Cloud Node:** Add region parameter to Venafi
protect cloud ([#7689](#7689))
([a08fca5](a08fca5))


### Performance Improvements

* **core:** Lazyload security audit reporters
([#7696](#7696))
([b2ca050](b2ca050))

Co-authored-by: ivov <ivov@users.noreply.github.com>
@janober
Copy link
Member

janober commented Nov 15, 2023

Got released with n8n@1.17.0

@netroy netroy mentioned this pull request Nov 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutdmour mutdmour mutdmour approved these changes

@gandreini gandreini Awaiting requested review from gandreini

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RicardoE105 @janober @mutdmour @gandreini