-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): Set postgres search_path to the desired schema on every connection #9530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
Enhancement outside /nodes-base and /editor-ui
n8n team
Authored by the n8n team
labels
May 28, 2024
netroy
force-pushed
the
fix-postgres-schema
branch
from
May 29, 2024 16:01
9c58a29
to
912c1cd
Compare
despairblue
previously approved these changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it and works.
1 flaky test on run #5177 ↗︎
Details:
cypress/e2e/5-ndv.cy.ts • 1 flaky test
Review all test suite changes for PR #9530 ↗︎ |
✅ All Cypress E2E specs passed |
netroy
force-pushed
the
fix-postgres-schema
branch
from
May 30, 2024 08:01
912c1cd
to
2fe3759
Compare
despairblue
approved these changes
May 30, 2024
|
✅ All Cypress E2E specs passed |
Merged
Got released with |
netroy
changed the title
fix(core): Try setting postgres search_path on the database
fix(core): Set postgres search_path to the desired schema on every connection
May 30, 2024
MiloradFilipovic
added a commit
that referenced
this pull request
May 31, 2024
* master: fix(editor): Fix ts errors across the board (no-changelog) (#9561) refactor(core): Extract all Auth-related User columns into a separate entity (#9557) refactor(core): Update supertest, and fix some typing errors (no-changelog) (#9527) fix(editor): Render checkboxes in markdown (#9549) test(core): Rename and combine all credential api tests (no-changelog) (#9550) 🚀 Release 1.44.0 (#9553) feat(editor): Node Creator AI nodes improvements (#9484) fix(editor): Show workflow data in header when execution page is hard reloaded (#9529) refactor(core): Stop reporting to Sentry `NodeApiError` with 5xx status codes (no-changelog) (#9552) feat: HighLevel oauth2 api credentials (#9542) fix(editor): Fix empty node name handling (#9548) ci: Fix vulnerable dev dependencies (no-changelog) (#9545) fix: Don't throw errors for NaN in number operators in the filter component (#9506) fix(core): Try setting postgres search_path on the database (#9530) fix(editor): Redirect to workflows list after deleting a workflow (#9546) # Conflicts: # packages/editor-ui/src/views/NodeView.vue # pnpm-lock.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typeorm PR n8n-io/typeorm#13
Related tickets and issues
https://community.n8n.io/t/update-fails-1-43-0/47066/13
Review / Merge checklist