Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Revert transactions until we remove the legacy sqlite driver #10299

Merged
merged 2 commits into from
Aug 5, 2024
Merged

fix(core): Revert transactions until we remove the legacy sqlite driver #10299

merged 2 commits into from
Aug 5, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented Aug 5, 2024 •
edited
Loading

Summary

We added a transaction around execution creation here, which in theory is a good idea, however because we are still using the non-pooling driver by default for sqlite, these transactions create nested transactions, possibly messing the DB us under highly concurrent load.
We should bring this transaction back once we remove the legacy driver.

Workflow Tests

Review / Merge checklist

  • PR title and summary are descriptive

@netroy netroy requested a review from tomi August 5, 2024 13:28
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Aug 5, 2024
tomi
tomi approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 5, 2024

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress Cypress
Copy link

cypress bot commented Aug 5, 2024 •
edited
Loading


Test summary

394 • 0 • 0 • 0 • Flakiness 0

Run details
Project n8n
Status Passed
Commit 1eba7c3
Started Aug 6, 2024 3:11 AM
Ended Aug 6, 2024 3:15 AM
Duration 04:38 💡
OS Linux Debian -
Browser Electron 118

View run in Cypress Cloud ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 5, 2024

✅ All Cypress E2E specs passed

@netroy netroy merged commit 1eba7c3 into master Aug 5, 2024
33 of 34 checks passed
@netroy netroy deleted the fix-executions branch August 5, 2024 16:10
MiloradFilipovic added a commit that referenced this pull request Aug 6, 2024
@MiloradFilipovic
Merge branch 'master' into ask-assistant
12c4d18 
* master:
  fix(core): Revert transactions until we remove the legacy sqlite driver  (#10299)
  refactor(editor): Boost n8n Form Trigger in nodes-panel search results (#10294)
  fix(core): Move error obfuscation to FE (no-changelog) (#10237)
@github-actions github-actions bot mentioned this pull request Aug 7, 2024
Merged
@janober
Copy link
Member

janober commented Aug 7, 2024

Got released with n8n@1.54.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomi tomi tomi approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@netroy @janober @tomi