Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Notion Node): Allow UUID v8 in notion id checks #10938

Merged
merged 1 commit into from
Sep 24, 2024
Merged

fix(Notion Node): Allow UUID v8 in notion id checks #10938

merged 1 commit into from
Sep 24, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented Sep 23, 2024

Summary

This PR

  1. Updated all our notion regexps to allow non-standard UUIDs that notion has started using
  2. Reduced the code duplication where we had 24 copies if what's essentially just 3 regexps.

Related Linear tickets, Github issues, and Community forum posts

NODE-1761
https://community.n8n.io/t/notion-node-bug-the-relation-id-fffbfe90567a-8132-b56d-c3acc1e8eb71-is-not-a-valid-uuid-with-optional-dashes/52258/29

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Sep 23, 2024
Joffcom
Joffcom approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@Joffcom Joffcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done some testing with new pages and spaces and old pages and spaces and all of the links I tried work.

@cypress Cypress
Copy link

cypress bot commented Sep 24, 2024

n8n    Run #7015

Run Properties:  status check passed Passed #7015  •  git commit 63497ae6c0: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project n8n
Branch Review NODE-1761-fix-notion-extractValue
Run status status check passed Passed #7015
Run duration 04m 25s
Commit git commit 63497ae6c0: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Committer कारतोफ्फेलस्क्रिप्ट™
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 432
View all changes introduced in this branch ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit 46beda0 into master Sep 24, 2024
33 checks passed
@netroy netroy deleted the NODE-1761-fix-notion-extractValue branch September 24, 2024 10:38
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
Merged
@janober
Copy link
Member

janober commented Sep 25, 2024

Got released with n8n@1.61.0

@Joffcom Joffcom mentioned this pull request Sep 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joffcom Joffcom Joffcom approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@netroy @janober @Joffcom