Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fail the build if package-lock.json is out of sync #4101

Merged
merged 2 commits into from
Sep 14, 2022

Conversation

netroy
Copy link
Member

@netroy netroy commented Sep 14, 2022

we have way too often that people are updating package.json files, but forgetting to update the package-lock.json.
not only does this create updates to package-lock.json in unrelated commits, it also breaks the nightly image builds as we are already using npm ci there.

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Sep 14, 2022
@netroy netroy merged commit b2807ce into master Sep 14, 2022
@netroy netroy deleted the enfore-updated-package-lock.json branch September 14, 2022 13:29
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Sep 14, 2022
@janober
Copy link
Member

janober commented Sep 15, 2022

Got released with n8n@0.194.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Sep 15, 2022
netroy added a commit that referenced this pull request Sep 19, 2022
netroy added a commit that referenced this pull request Sep 19, 2022
… to date (#4135)

* Revert "ci: fail the build if `package-lock.json` is out of sync (#4101)"

This reverts commit b2807ce.

* Update package-lock.json
valya pushed a commit to valya/n8n that referenced this pull request Nov 8, 2022
valya pushed a commit to valya/n8n that referenced this pull request Nov 8, 2022
… to date (n8n-io#4135)

* Revert "ci: fail the build if `package-lock.json` is out of sync (n8n-io#4101)"

This reverts commit b2807ce.

* Update package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants