Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): Fix redo in code and expression editor #5708

Merged
merged 2 commits into from
Mar 17, 2023
Merged

fix(editor): Fix redo in code and expression editor #5708

merged 2 commits into from
Mar 17, 2023

Conversation

MiloradFilipovic
Copy link
Contributor

Fixes #5298

@MiloradFilipovic MiloradFilipovic self-assigned this Mar 16, 2023
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Mar 16, 2023
@MiloradFilipovic MiloradFilipovic marked this pull request as draft March 16, 2023 16:15
@MiloradFilipovic MiloradFilipovic marked this pull request as ready for review March 17, 2023 09:01
@MiloradFilipovic MiloradFilipovic merged commit cd7a55b into master Mar 17, 2023
@MiloradFilipovic MiloradFilipovic deleted the ADO-335-codemirror-redo-fix branch March 17, 2023 12:23
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 17, 2023
@janober
Copy link
Member

janober commented Mar 26, 2023

Got released with n8n@0.221.2

@janober
Copy link
Member

janober commented Mar 26, 2023

Got released with n8n@0.221.2

sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
@MiloradFilipovic @sunilrr
fix(editor): Fix redo in code and expression editor (n8n-io#5708)
a5860ac 
* fix(editor): Fix redo in code and expression editor
* ⚡ Updating keymap to use platform-specific command key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlegIvaniv OlegIvaniv OlegIvaniv approved these changes

Assignees

@MiloradFilipovic MiloradFilipovic

Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system Upcoming Release Will be part of the upcoming release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redo functionality is not available in expression fields or code nodes
3 participants
@MiloradFilipovic @janober @OlegIvaniv