Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): Fix inverted checks on modal confirmation results #6285

Merged
merged 4 commits into from
May 23, 2023
Merged

fix(editor): Fix inverted checks on modal confirmation results #6285

merged 4 commits into from
May 23, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented May 19, 2023

No description provided.

@netroy netroy requested a review from cstuncsik May 19, 2023 17:02
@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2023 •
edited
Loading

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented May 19, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (d5c7e6f) 27.65% compared to head (2611ae5) 27.65%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6285      +/-   ##
==========================================
- Coverage   27.65%   27.65%   -0.01%     
==========================================
  Files        2948     2957       +9     
  Lines      180896   181306     +410     
  Branches    19646    19724      +78     
==========================================
+ Hits        50019    50132     +113     
- Misses     130130   130427     +297     
  Partials      747      747
Impacted Files Coverage Δ
...i/src/components/CredentialEdit/CredentialEdit.vue 0.00% <0.00%> (ø)

... and 21 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels May 19, 2023
cstuncsik
cstuncsik previously approved these changes May 19, 2023
View reviewed changes
@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@Joffcom Joffcom mentioned this pull request May 21, 2023
Closed
alexgrozav
alexgrozav previously approved these changes May 22, 2023
View reviewed changes
@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

cstuncsik
cstuncsik reviewed May 23, 2023
View reviewed changes
packages/editor-ui/src/mixins/workflowHelpers.ts Outdated
@@ -766,7 +766,7 @@ export const workflowHelpers = defineComponent({
},
);

if (overwrite === MODAL_CONFIRM) {
if (overwrite !== MODAL_CONFIRM) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this

@cstuncsik cstuncsik dismissed stale reviews from alexgrozav and themself via 6733dfd May 23, 2023 13:27
@cstuncsik cstuncsik requested a review from alexgrozav May 23, 2023 13:54
@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

2 similar comments
@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@cstuncsik cstuncsik merged commit 5d2f474 into master May 23, 2023
@cstuncsik cstuncsik deleted the fix-modal-confirm-checks branch May 23, 2023 17:09
@janober
Copy link
Member

janober commented May 25, 2023

Got released with n8n@0.230.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstuncsik cstuncsik cstuncsik approved these changes

@alexgrozav alexgrozav Awaiting requested review from alexgrozav

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@netroy @janober @cstuncsik @alexgrozav