feat(core): Descriptive message for common nodeJS errors #6841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…common-errors-thrown-by-nodejs
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Make sure to check off this list before asking for review. |
netroy
requested changes
Aug 3, 2023
…common-errors-thrown-by-nodejs
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6841 +/- ##
==========================================
+ Coverage 24.77% 24.78% +0.01%
==========================================
Files 3130 3130
Lines 190824 190848 +24
Branches 21020 21022 +2
==========================================
+ Hits 47268 47297 +29
+ Misses 142598 142591 -7
- Partials 958 960 +2
☔ View full report in Codecov by Sentry. |
netroy
approved these changes
Aug 14, 2023
1 flaky tests on run #1867 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Webhook Trigger node > should listen for a GET request |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
|
✅ All Cypress E2E specs passed |
|
looks like this change might be breaking the workflow tests https://github.com/n8n-io/n8n/actions/runs/5862793654/job/15895155750 |
Merged
netroy
added a commit
that referenced
this pull request
Aug 16, 2023
# [1.3.0](https://github.com/n8n-io/n8n/compare/n8n@1.2.0...n8n@1.3.0) (2023-08-16) ### Bug Fixes * **core:** Don't let bull override the default redis config ([#6897](#6897)) ([cfeb322](cfeb322)) * **core:** Fix fetching of EE executions ([#6901](#6901)) ([f3fce48](f3fce48)) * **core:** Update frontend urls when using the `--tunnel` option ([#6898](#6898)) ([718e613](718e613)) * **editor:** Disable telemetry in dev mode and in E2E tests ([#6869](#6869)) ([808a928](808a928)) * **editor:** Fix code node’s content property to be reactive ([#6931](#6931)) ([3b75bc6](3b75bc6)) * **editor:** Fix event emit on credential sharing ([#6922](#6922)) ([297c3c9](297c3c9)) * **editor:** Fix multiOptions parameters resetting on initial load ([#6903](#6903)) ([49867c2](49867c2)) * **editor:** Update execution view layout ([#6882](#6882)) ([0339732](0339732)) * **Email Trigger (IMAP) Node:** Fix connection issue with unexpected spaces in host ([#6886](#6886)) ([f3248e4](f3248e4)) * Fix issue with key formatting if null or undefined ([#6924](#6924)) ([4e4a3cf](4e4a3cf)) * Fix issue with key formatting introduced in 1.2.0 ([#6896](#6896)) ([0e075c9](0e075c9)) * Fix lag when node parameters are updated ([#6941](#6941)) ([3eb65e0](3eb65e0)) * **HTTP Request Node:** Improve error handling for TCP socket errors when `Continue On Fail` is enabled ([#6925](#6925)) ([96ff1f8](96ff1f8)) * Prevent workflow breaking when credential type is unknown ([#6923](#6923)) ([e83b93f](e83b93f)) * **Respond to Webhook Node:** Return headers in response ([#6921](#6921)) ([a82107f](a82107f)) ### Features * **core:** Add support for not requiring SMTP auth with user management ([#3742](#3742)) ([eead6d4](eead6d4)) * **core:** Descriptive message for common nodeJS errors ([#6841](#6841)) ([3adb0b6](3adb0b6)) * **editor:** Ask AI in Code node ([#6672](#6672)) ([fde6ad1](fde6ad1)) * Enable parallel processing on multiple queue nodes ([#6295](#6295)) ([44afcff](44afcff)) Co-authored-by: netroy <netroy@users.noreply.github.com>
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue / Community forum post (link here to close automatically):