fix(editor): Fix SQL editor issue #7236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-radency
added
ui
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
mutdmour
reviewed
Sep 22, 2023
| @@ -120,7 +120,7 @@ | |||
| :dialect="getArgument('sqlDialect')" | |||
| :isReadOnly="isReadOnly" | |||
| :rows="getArgument('rows')" | |||
| @valueChanged="valueChangedDebounced" | |||
| @update:modelValue="valueChangedDebounced" | |||
There was a problem hiding this comment.
can you please add tests that address this bug?
mutdmour
reviewed
Sep 22, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #7236 +/- ##
==========================================
- Coverage 32.83% 32.83% -0.01%
==========================================
Files 3351 3351
Lines 199977 199972 -5
Branches 21927 21918 -9
==========================================
- Hits 65665 65658 -7
- Misses 133203 133205 +2
Partials 1109 1109
☔ View full report in Codecov by Sentry. |
…fix-sql-editor-changes
…fix-sql-editor-changes
mutdmour
reviewed
Sep 22, 2023
| const state = EditorState.create({ | ||
| doc, | ||
| doc: this.modelValue ?? this.placeholder, |
There was a problem hiding this comment.
is this reverting a change? why are we adding the placeholder here?
There was a problem hiding this comment.
no, we are not changing this line, this is how it was set on master
There was a problem hiding this comment.
so removing placeholder was a bug?
There was a problem hiding this comment.
do we need a test for this then?
There was a problem hiding this comment.
no, placeholder was never removed, bug was in this line @valueChanged="valueChangedDebounced" that remained in sql editor template,
after, on master, it was updated to @update:modelValue="valueChangedDebounced" previous method for adjusting editor height stop working, so I had to revisit solution, now it's more cleaner
mutdmour
approved these changes
Sep 22, 2023
Passing run #2247 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
|
✅ All Cypress E2E specs passed |
netroy
pushed a commit
that referenced
this pull request
Sep 25, 2023
Github issue / Community forum post (link here to close automatically):
Merged
netroy
added a commit
that referenced
this pull request
Sep 25, 2023
## [1.8.2](https://github.com/n8n-io/n8n/compare/n8n@1.8.1...n8n@1.8.2) (2023-09-25) ### Bug Fixes * **editor:** Add debug feature docs link ([#7240](#7240)) ([1b2ccca](1b2ccca)) * **editor:** Fix SQL editor issue ([#7236](#7236)) ([539f954](539f954)) ### Reverts * Revert "fix: Issue enforcing user limits on start plan (#7188)" ([6589580](6589580)) Co-authored-by: netroy <netroy@users.noreply.github.com>
|
Got released with |
netroy
added a commit
that referenced
this pull request
Sep 28, 2023
# [1.9.0](https://github.com/n8n-io/n8n/compare/n8n@1.8.0...n8n@1.9.0) (2023-09-28) ### Bug Fixes * **Airtable Node:** Attachments field type fix ([#7227](#7227)) ([2af967c](2af967c)) * **core:** Change WorkflowHistory nodes/connections columns to be json ([#7282](#7282)) ([a80abad](a80abad)) * **core:** Fix binary data manager check on pruning ([#7251](#7251)) ([484035e](484035e)) * **core:** Fix missing execution ID in webhook-based workflow producing binary data ([#7244](#7244)) ([33991e9](33991e9)) * **core:** Handle filename* with quotes in Content-Disposition header ([#7229](#7229)) ([67b985f](67b985f)) * **core:** Make DNS resolution order configurable ([#7272](#7272)) ([5b3121c](5b3121c)) * **core:** Make senderId required for all command messages ([#7252](#7252)) ([4b01428](4b01428)) * **core:** Prevent executions from displaying Running status incorrectly ([#7261](#7261)) ([861cac5](861cac5)) * **core:** Use consistent timezone-aware timestamps in postgres ([#6948](#6948)) ([0132514](0132514)), closes [#2178](#2178) [#2810](#2810) [#3855](#3855) [#2813](#2813) * **editor:** Add debug feature docs link ([#7240](#7240)) ([4614e1e](4614e1e)) * **editor:** Fix SQL editor issue ([#7236](#7236)) ([647fc6c](647fc6c)) * **editor:** Ensure new Set node is on top of search list ([#7215](#7215)) ([2491ccf](2491ccf)) * **editor:** Forbid password reset when cloud account is limited in the number of users [7188](#7188) ([303bc8e](303bc8e)) * **HTTP Request Node:** Add suggestion how to fix '429 - too many requests' errors ([#7293](#7293)) ([0bc33b1](0bc33b1)) * **Item Lists Node:** Concatenate operation pairedItems fix ([#7286](#7286)) ([cde23a1](cde23a1)) * **Respond to Webhook Node:** JSON output from expression fix ([#7294](#7294)) ([8bc369d](8bc369d)) ### Features * Add onboarding flow ([#7212](#7212)) ([01e9340](01e9340)) * **core:** Add secrets provider reload and refactor ([#7277](#7277)) ([53a7502](53a7502)) * **core:** Add Tournament as the new default expression evaluator ([#6964](#6964)) ([bf74f09](bf74f09)) * **core:** Initial workflow history API ([#7234](#7234)) ([0083a9e](0083a9e)) * **core:** Introduce object store service ([#7225](#7225)) ([fa84545](fa84545)) * **editor:** Add user cloud ID to telemetry [#7232](#7232) ([60c152d](60c152d)) * **editor:** Rework banners framework and add email confirmation banner ([#7205](#7205)) ([b0e98b5](b0e98b5)) * **MISP Node:** Update credential to support HTTP Request node ([#7268](#7268)) ([e4c302c](e4c302c)) ### Performance Improvements * **core:** Skip unneeded calls on every pruning cycle ([#7260](#7260)) ([db01164](db01164)) Co-authored-by: netroy <netroy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue / Community forum post (link here to close automatically):