fix(core): Fix ignoring crashed executions without event msgs #7368

flipswitchingmonkey · 2023-10-06T12:03:55Z

when the event logs do not contain messages for running executions, the recovery/crash detection on startup would skip these. this PR fixes that.

github-actions · 2023-10-06T12:04:12Z

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

If fixing bug, added test to cover scenario.
If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

packages/cli/src/eventbus/MessageEventBus/MessageEventBus.ts

codecov · 2023-10-06T12:32:48Z

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (2b075bf) 33.50% compared to head (075533d) 33.50%.
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #7368   +/-   ##
=======================================
  Coverage   33.50%   33.50%           
=======================================
  Files        3389     3389           
  Lines      207020   207028    +8     
  Branches    22337    22342    +5     
=======================================
+ Hits        69361    69365    +4     
- Misses     136538   136542    +4     
  Partials     1121     1121

Files	Coverage Δ
.../cli/src/eventbus/MessageEventBus/recoverEvents.ts	`9.72% <ø> (ø)`
...li/src/eventbus/MessageEventBus/MessageEventBus.ts	`44.33% <50.00%> (+0.22%)`	⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/cli/src/databases/repositories/execution.repository.ts

packages/cli/src/eventbus/MessageEventBus/MessageEventBus.ts

…-eventlog

packages/cli/src/databases/repositories/execution.repository.ts

packages/cli/test/integration/eventbus.ee.test.ts

packages/cli/src/databases/repositories/execution.repository.ts

packages/cli/src/eventbus/MessageEventBus/MessageEventBus.ts

cypress · 2023-10-11T10:57:09Z

1 flaky test on run #2471 ↗︎

0	251	0	0	1

Details:

🌳 pay-875-exec-recovery-not-handling-when-no-eventlog 🖥️ browsers:node18.12.0-...
Project: n8n	Commit: `075533d072`
Status: Passed	Duration: 08:16 💡
Started: Oct 11, 2023 12:05 PM	Ended: Oct 11, 2023 12:13 PM

cypress/e2e/2-credentials.cy.ts • 1 flaky test

View Output Video

Test		Artifacts
Credentials > should create a new credential using Add Credential button		`Output` `Screenshots` `Video`

Review all test suite changes for PR #7368 ↗︎

github-actions · 2023-10-11T10:57:14Z

✅ All Cypress E2E specs passed

…-eventlog

github-actions · 2023-10-11T12:13:30Z

✅ All Cypress E2E specs passed

* master: fix(core): Fix ignoring crashed executions without event msgs (#7368) ci: Enable ARM64 builds for beta images (no-changelog) (#7403) 🚀 Release 1.11.0 (#7402) fix(editor): Sanitize HTML binary-data before rendering in the UI (#7400) fix(core): Fix error on missing paired item data (#7399) feat(editor): Workflow history [WIP]- Create workflow history item preview component (no-changelog) (#7378) feat(Item Lists Node): Split merge binary data (#7297) fix(core): Missing pairing info (#7326) fix(Webhook Node): Backward compatible form-data parsing for non-array files (#7385)

when the event logs do not contain messages for running executions, the recovery/crash detection on startup would skip these. this PR fixes that.

## [1.11.1](https://github.com/n8n-io/n8n/compare/n8n@1.11.0...n8n@1.11.1) (2023-10-13) ### Bug Fixes * **core:** Do not throw when deleting workflows with executions without binary-data ([#7411](#7411)) ([cde331d](cde331d)) * **core:** Fix ignoring crashed executions without event msgs ([#7368](#7368)) ([ca0d4d2](ca0d4d2)) * **editor:** Fix remote options fetching on every keystroke ([#7320](#7320)) ([15f891b](15f891b)) * Prevent undefined issues when restoring binary data ([#7419](#7419)) ([5da8dcb](5da8dcb)) Co-authored-by: krynble <krynble@users.noreply.github.com>

janober · 2023-10-17T16:27:42Z

Got released with n8n@1.11.1

# [1.12.0](https://github.com/n8n-io/n8n/compare/n8n@1.11.0...n8n@1.12.0) (2023-10-18) ### Bug Fixes * **core:** Add check that queue is defined and remove cyclic dependency ([#7404](#7404)) ([45f2ef3](45f2ef3)) * **core:** Do not throw when deleting workflows with executions without binary-data ([#7411](#7411)) ([2b6a15e](2b6a15e)) * **core:** Fix expression with paired item with multi-input node ([#7424](#7424)) ([ec14141](ec14141)) * **core:** Fix ignoring crashed executions without event msgs ([#7368](#7368)) ([2f4d91b](2f4d91b)) * **core:** Pg-promise de-initialization fix ([#7417](#7417)) ([7703904](7703904)) * **core:** Prevent false stalled jobs in queue mode from displaying as errored ([#7435](#7435)) ([e01b9e5](e01b9e5)) * **core:** Prevent undefined issues when restoring binary data ([#7419](#7419)) ([46977a2](46977a2)) * **editor:** Fix remote options fetching on every keystroke ([#7320](#7320)) ([367255a](367255a)) * **editor:** Open only one tab with plans page ([#7377](#7377)) ([c599006](c599006)) * **Google Sheets Node:** Update by row_number, restored 'Handling Extra Data Option', updated Cell Format default ([#7357](#7357)) ([d8531a5](d8531a5)) * **Ldap Node:** Fix issue with connections not closing correctly ([#7432](#7432)) ([c3f0be8](c3f0be8)) * **Set Node:** Null should not throw an error ([#7416](#7416)) ([e9b6ab0](e9b6ab0)) * **TheHive 5 Node:** Observable encoding in alert > create fix ([#7450](#7450)) ([a2d2e3d](a2d2e3d)) ### Features * **core:** Make executions pruning interval configurable ([#7439](#7439)) ([40707fa](40707fa)) * **Google Calendar Trigger Node:** Add support for cancelled events ([#7436](#7436)) ([9d241a0](9d241a0)) * **HubSpot Trigger Node:** Add support for ticket related events ([#7156](#7156)) ([57c6093](57c6093)) * **n8n Form Trigger Node:** New node ([#7130](#7130)) ([3ddc176](3ddc176)) * **Spreadsheet File Node:** Improve CSV parsing ([#7448](#7448)) ([79f23fb](79f23fb)) Co-authored-by: netroy <netroy@users.noreply.github.com>

when the event logs do not contain messages for running executions, the recovery/crash detection on startup would skip these. this PR fixes that.

# [1.12.0](https://github.com/n8n-io/n8n/compare/n8n@1.11.0...n8n@1.12.0) (2023-10-18) ### Bug Fixes * **core:** Add check that queue is defined and remove cyclic dependency ([#7404](#7404)) ([45f2ef3](45f2ef3)) * **core:** Do not throw when deleting workflows with executions without binary-data ([#7411](#7411)) ([2b6a15e](2b6a15e)) * **core:** Fix expression with paired item with multi-input node ([#7424](#7424)) ([ec14141](ec14141)) * **core:** Fix ignoring crashed executions without event msgs ([#7368](#7368)) ([2f4d91b](2f4d91b)) * **core:** Pg-promise de-initialization fix ([#7417](#7417)) ([7703904](7703904)) * **core:** Prevent false stalled jobs in queue mode from displaying as errored ([#7435](#7435)) ([e01b9e5](e01b9e5)) * **core:** Prevent undefined issues when restoring binary data ([#7419](#7419)) ([46977a2](46977a2)) * **editor:** Fix remote options fetching on every keystroke ([#7320](#7320)) ([367255a](367255a)) * **editor:** Open only one tab with plans page ([#7377](#7377)) ([c599006](c599006)) * **Google Sheets Node:** Update by row_number, restored 'Handling Extra Data Option', updated Cell Format default ([#7357](#7357)) ([d8531a5](d8531a5)) * **Ldap Node:** Fix issue with connections not closing correctly ([#7432](#7432)) ([c3f0be8](c3f0be8)) * **Set Node:** Null should not throw an error ([#7416](#7416)) ([e9b6ab0](e9b6ab0)) * **TheHive 5 Node:** Observable encoding in alert > create fix ([#7450](#7450)) ([a2d2e3d](a2d2e3d)) ### Features * **core:** Make executions pruning interval configurable ([#7439](#7439)) ([40707fa](40707fa)) * **Google Calendar Trigger Node:** Add support for cancelled events ([#7436](#7436)) ([9d241a0](9d241a0)) * **HubSpot Trigger Node:** Add support for ticket related events ([#7156](#7156)) ([57c6093](57c6093)) * **n8n Form Trigger Node:** New node ([#7130](#7130)) ([3ddc176](3ddc176)) * **Spreadsheet File Node:** Improve CSV parsing ([#7448](#7448)) ([79f23fb](79f23fb)) Co-authored-by: netroy <netroy@users.noreply.github.com>

fix ignoring crashed executions without event msgs

77a76e9

flipswitchingmonkey added the skip-e2e label Oct 6, 2023

mutdmour reviewed Oct 6, 2023

View reviewed changes

packages/cli/src/eventbus/MessageEventBus/MessageEventBus.ts Show resolved Hide resolved

n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Oct 6, 2023

ivov reviewed Oct 6, 2023

View reviewed changes

packages/cli/src/databases/repositories/execution.repository.ts Outdated Show resolved Hide resolved

packages/cli/src/eventbus/MessageEventBus/MessageEventBus.ts Outdated Show resolved Hide resolved

packages/cli/src/eventbus/MessageEventBus/MessageEventBus.ts Outdated Show resolved Hide resolved

flipswitchingmonkey added 3 commits October 11, 2023 08:35

Merge branch 'master' into pay-875-exec-recovery-not-handling-when-no…

e865258

…-eventlog

cleanup

b962c61

add test

2cebb3b

flipswitchingmonkey requested review from ivov and mutdmour October 11, 2023 08:17

ivov reviewed Oct 11, 2023

View reviewed changes

address comments

dd8d479

flipswitchingmonkey requested a review from ivov October 11, 2023 10:40

ivov previously approved these changes Oct 11, 2023

View reviewed changes

flipswitchingmonkey added 2 commits October 11, 2023 12:58

Merge branch 'master' into pay-875-exec-recovery-not-handling-when-no…

3f7716b

…-eventlog

skip tests in CI

075533d

flipswitchingmonkey dismissed ivov’s stale review via 075533d October 11, 2023 11:27

flipswitchingmonkey requested a review from ivov October 11, 2023 11:27

ivov approved these changes Oct 11, 2023

View reviewed changes

flipswitchingmonkey merged commit 2f4d91b into master Oct 11, 2023
54 of 55 checks passed

flipswitchingmonkey deleted the pay-875-exec-recovery-not-handling-when-no-eventlog branch October 11, 2023 12:22

github-actions bot mentioned this pull request Oct 12, 2023

🚀 Release 1.11.1 #7426

Merged

janober added the Released label Oct 17, 2023

github-actions bot mentioned this pull request Oct 18, 2023

🚀 Release 1.12.0 #7459

Merged

elsmr pushed a commit that referenced this pull request Oct 19, 2023

fix(core): Fix ignoring crashed executions without event msgs (#7368)

fd6b491

when the event logs do not contain messages for running executions, the recovery/crash detection on startup would skip these. this PR fixes that.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(core): Fix ignoring crashed executions without event msgs #7368

fix(core): Fix ignoring crashed executions without event msgs #7368

flipswitchingmonkey commented Oct 6, 2023

github-actions bot commented Oct 6, 2023

codecov bot commented Oct 6, 2023 •

edited

Loading

cypress bot commented Oct 11, 2023 •

edited

Loading

github-actions bot commented Oct 11, 2023

github-actions bot commented Oct 11, 2023

janober commented Oct 17, 2023

fix(core): Fix ignoring crashed executions without event msgs #7368

fix(core): Fix ignoring crashed executions without event msgs #7368

Conversation

flipswitchingmonkey commented Oct 6, 2023

github-actions bot commented Oct 6, 2023

codecov bot commented Oct 6, 2023 • edited Loading

Codecov Report

cypress bot commented Oct 11, 2023 • edited Loading

1 flaky test on run #2471 ↗︎

Review all test suite changes for PR #7368 ↗︎

github-actions bot commented Oct 11, 2023

github-actions bot commented Oct 11, 2023

janober commented Oct 17, 2023

codecov bot commented Oct 6, 2023 •

edited

Loading

cypress bot commented Oct 11, 2023 •

edited

Loading