Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Item Lists Node): Split merge binary data #7297

Merged
merged 16 commits into from Oct 11, 2023
Merged

feat(Item Lists Node): Split merge binary data #7297

merged 16 commits into from Oct 11, 2023

Conversation

michael-radency
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@michael-radency michael-radency added node/improvement New feature or request n8n team Authored by the n8n team labels Sep 28, 2023
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Sep 28, 2023 •
edited

Codecov Report

Attention: 51 lines in your changes are missing coverage. Please review.

Comparison is base (e2c3c7a) 33.43% compared to head (e6a12ab) 33.42%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7297      +/-   ##
==========================================
- Coverage   33.43%   33.42%   -0.01%     
==========================================
  Files        3389     3389              
  Lines      206777   206819      +42     
  Branches    22315    22323       +8     
==========================================
+ Hits        69131    69134       +3     
- Misses     136526   136563      +37     
- Partials     1120     1122       +2
Files Coverage Δ
.../V3/actions/itemList/concatenateItems.operation.ts 60.43% <50.00%> (-3.85%) ⬇️
...ges/nodes-base/nodes/ItemLists/V3/helpers/utils.ts 47.69% <12.00%> (-23.04%) ⬇️
...sts/V3/actions/itemList/splitOutItems.operation.ts 50.64% <36.11%> (-5.42%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

michael-radency and others added 12 commits September 29, 2023 10:14
@michael-radency
⚡ options
adef794
@michael-radency
Merge branch 'master' of https://github.com/n8n-io/n8n into node-658-…
4abb12c 
…item-lists-merge-binary-data
@michael-radency
⚡ include binaries option to aggregate operation
00d1c39
@michael-radency
⚡ include binary option for splited items
4136d26
@michael-radency
Merge branch 'master' of https://github.com/n8n-io/n8n into node-658-…
6a7b6c4 
…item-lists-merge-binary-data
@michael-radency
⚡ adding support to split by binaries to splitItems, WIP
eca9e98
@michael-radency
Merge branch 'master' of https://github.com/n8n-io/n8n into node-658-…
f2a2a9a 
…item-lists-merge-binary-data
@michael-radency
Merge branch 'master' of https://github.com/n8n-io/n8n into node-658-…
6c33465 
…item-lists-merge-binary-data
@michael-radency
⚡ split by support
7fd5b0e
@michael-radency
Merge branch 'master' of https://github.com/n8n-io/n8n into node-658-…
2e34db8 
…item-lists-merge-binary-data
@michael-radency
⚡ added placeholder, updated description
54e749d
@maspio
split out items - do not delete binary for new items to support $bina…
a043e0d 
…ry fields
@cypress
Copy link

cypress bot commented Oct 10, 2023 •
edited

Passing run #2461 ↗︎

0 251 0 0 Flakiness 0

Details:

🌳 node-658-item-lists-merge-binary-data 🖥️ browsers:node18.12.0-chrome107 🤖 m...
Project: n8n Commit: e6a12ab822
Status: Passed Duration: 07:57 💡
Started: Oct 11, 2023 6:42 AM Ended: Oct 11, 2023 6:50 AM

Review all test suite changes for PR #7297 ↗︎

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit 965db8f into master Oct 11, 2023
55 checks passed
@michael-radency michael-radency deleted the node-658-item-lists-merge-binary-data branch October 11, 2023 07:59
@github-actions github-actions bot mentioned this pull request Oct 11, 2023
Merged
netroy added a commit that referenced this pull request Oct 11, 2023
@github-actions @netroy
🚀 Release 1.11.0 (#7402)
e6ba841 
# [1.11.0](https://github.com/n8n-io/n8n/compare/n8n@1.10.0...n8n@1.11.0)
(2023-10-11)


### Bug Fixes

* **core:** Add an option to enable postgres ssl with default certs
([#6889](#6889))
([789e1e7](789e1e7))
* **core:** Fix error on missing paired item data
([#7399](#7399))
([47e8953](47e8953))
* **core:** Missing pairing info
([#7326](#7326))
([e2c3c7a](e2c3c7a))
* **core:** Prevent object deletion request on no prefix match
([#7366](#7366))
([63e11e4](63e11e4))
* **editor:** Fix completions for `.json` on quoted node name in Code
node ([#7382](#7382))
([86e7ec7](86e7ec7))
* **editor:** Implement canvas zoom UX improvements
([#7376](#7376))
([7e06b31](7e06b31))
* **editor:** Make workflow history button available only for dev builds
([#7392](#7392))
([7ed466d](7ed466d))
* **editor:** Remove excess margin below run data editor
([#7372](#7372))
([3fa2764](3fa2764))
* **editor:** Sanitize HTML binary-data before rendering in the UI
([#7400](#7400))
([2b075bf](2b075bf))
* **editor:** Use display option's @Version specifier
([#7351](#7351))
([afbf0c3](afbf0c3))
* **Google BigQuery Node:** Location default to jobReference
([#7354](#7354))
([97bb703](97bb703))
* **Google Drive Trigger Node:** Add Shared Drives support
([#7369](#7369))
([3e7a4d3](3e7a4d3))
* **Google Sheets Node:** Fix "Maximum call stack size exceeded" error
on too many rows ([#7384](#7384))
([732b15a](732b15a))
* **HTML Node:** Update property fields to not use expressions on drag
([#7379](#7379))
([77643e5](77643e5))
* **Notion Node:** Handle empty values correctly for Notion selects +
multi selects ([#7383](#7383))
([fbcd1d4](fbcd1d4))
* **Set Node:** Increase search priority
([#7358](#7358))
([e5ad1e7](e5ad1e7))
* **Webhook Node:** Backward compatible form-data parsing for non-array
files ([#7385](#7385))
([6479eb1](6479eb1))


### Features

* **core:** Add Job Summary to Worker response
([#7360](#7360))
([b8608ce](b8608ce))
* **core:** Integrate object store as binary data manager
([#7253](#7253))
([1a661e6](1a661e6))
* **core:** Switch binary filesystem mode to nested path structure
([#7307](#7307))
([0847623](0847623))
* **editor:** Make PDF and Audio binary-data viewable in the UI
([#7367](#7367))
([8187be1](8187be1))
* **editor:** Support autologin for upgrade path
([#7316](#7316))
([1dfa052](1dfa052))
* **Execute Workflow Node:** Run once for each item mode
([#7289](#7289))
([c8c14ca](c8c14ca))
* **Item Lists Node:** Split merge binary data
([#7297](#7297))
([965db8f](965db8f))
* **Loop Over Items (Split in Batches) Node:** Automatically add a loop
+ rename ([#7228](#7228))
([7b773cc](7b773cc))
* **Notion Node:** Fetch child blocks recursively
([#7304](#7304))
([193181a](193181a))

Co-authored-by: netroy <netroy@users.noreply.github.com>
@janober
Copy link
Member

janober commented Oct 11, 2023

Got released with n8n@1.11.0

MiloradFilipovic added a commit that referenced this pull request Oct 11, 2023
@MiloradFilipovic
Merge branch 'master' into ADO-1148-remote-options-fix
e530d52 
* master:
  fix(core): Fix ignoring crashed executions without event msgs (#7368)
  ci: Enable ARM64 builds for beta images (no-changelog) (#7403)
  🚀 Release 1.11.0 (#7402)
  fix(editor): Sanitize HTML binary-data before rendering in the UI (#7400)
  fix(core): Fix error on missing paired item data (#7399)
  feat(editor): Workflow history [WIP]- Create workflow history item preview component (no-changelog) (#7378)
  feat(Item Lists Node): Split merge binary data (#7297)
  fix(core): Missing pairing info (#7326)
  fix(Webhook Node): Backward compatible form-data parsing for non-array files (#7385)
elsmr pushed a commit that referenced this pull request Oct 19, 2023
@github-actions @netroy @elsmr
🚀 Release 1.11.0 (#7402)
f10b5f0 
# [1.11.0](https://github.com/n8n-io/n8n/compare/n8n@1.10.0...n8n@1.11.0)
(2023-10-11)


### Bug Fixes

* **core:** Add an option to enable postgres ssl with default certs
([#6889](#6889))
([789e1e7](789e1e7))
* **core:** Fix error on missing paired item data
([#7399](#7399))
([47e8953](47e8953))
* **core:** Missing pairing info
([#7326](#7326))
([e2c3c7a](e2c3c7a))
* **core:** Prevent object deletion request on no prefix match
([#7366](#7366))
([63e11e4](63e11e4))
* **editor:** Fix completions for `.json` on quoted node name in Code
node ([#7382](#7382))
([86e7ec7](86e7ec7))
* **editor:** Implement canvas zoom UX improvements
([#7376](#7376))
([7e06b31](7e06b31))
* **editor:** Make workflow history button available only for dev builds
([#7392](#7392))
([7ed466d](7ed466d))
* **editor:** Remove excess margin below run data editor
([#7372](#7372))
([3fa2764](3fa2764))
* **editor:** Sanitize HTML binary-data before rendering in the UI
([#7400](#7400))
([2b075bf](2b075bf))
* **editor:** Use display option's @Version specifier
([#7351](#7351))
([afbf0c3](afbf0c3))
* **Google BigQuery Node:** Location default to jobReference
([#7354](#7354))
([97bb703](97bb703))
* **Google Drive Trigger Node:** Add Shared Drives support
([#7369](#7369))
([3e7a4d3](3e7a4d3))
* **Google Sheets Node:** Fix "Maximum call stack size exceeded" error
on too many rows ([#7384](#7384))
([732b15a](732b15a))
* **HTML Node:** Update property fields to not use expressions on drag
([#7379](#7379))
([77643e5](77643e5))
* **Notion Node:** Handle empty values correctly for Notion selects +
multi selects ([#7383](#7383))
([fbcd1d4](fbcd1d4))
* **Set Node:** Increase search priority
([#7358](#7358))
([e5ad1e7](e5ad1e7))
* **Webhook Node:** Backward compatible form-data parsing for non-array
files ([#7385](#7385))
([6479eb1](6479eb1))


### Features

* **core:** Add Job Summary to Worker response
([#7360](#7360))
([b8608ce](b8608ce))
* **core:** Integrate object store as binary data manager
([#7253](#7253))
([1a661e6](1a661e6))
* **core:** Switch binary filesystem mode to nested path structure
([#7307](#7307))
([0847623](0847623))
* **editor:** Make PDF and Audio binary-data viewable in the UI
([#7367](#7367))
([8187be1](8187be1))
* **editor:** Support autologin for upgrade path
([#7316](#7316))
([1dfa052](1dfa052))
* **Execute Workflow Node:** Run once for each item mode
([#7289](#7289))
([c8c14ca](c8c14ca))
* **Item Lists Node:** Split merge binary data
([#7297](#7297))
([965db8f](965db8f))
* **Loop Over Items (Split in Batches) Node:** Automatically add a loop
+ rename ([#7228](#7228))
([7b773cc](7b773cc))
* **Notion Node:** Fetch child blocks recursively
([#7304](#7304))
([193181a](193181a))

Co-authored-by: netroy <netroy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maspio maspio maspio approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michael-radency @janober @maspio