Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Google Sheets Node): Update by row_number, restored 'Handling Extra Data Option', updated Cell Format default #7357

Merged
merged 10 commits into from
Oct 17, 2023
Merged

fix(Google Sheets Node): Update by row_number, restored 'Handling Extra Data Option', updated Cell Format default #7357

merged 10 commits into from
Oct 17, 2023

Conversation

michael-radency
Copy link
Contributor

@michael-radency michael-radency commented Oct 5, 2023 •
edited by netroy
Loading

@michael-radency michael-radency added node/improvement New feature or request n8n team Authored by the n8n team node/issue Issue with a node labels Oct 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Oct 5, 2023 •
edited
Loading

Codecov Report

Attention: 217 lines in your changes are missing coverage. Please review.

Comparison is base (869b8f1) 33.51% compared to head (e2a8577) 33.49%.
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7357      +/-   ##
==========================================
- Coverage   33.51%   33.49%   -0.02%     
==========================================
  Files        3390     3392       +2     
  Lines      207084   207328     +244     
  Branches    22354    22375      +21     
==========================================
+ Hits        69394    69440      +46     
- Misses     136567   136764     +197     
- Partials     1123     1124       +1
Files Coverage Δ
...or-ui/src/components/Node/NodeCreator/viewsData.ts 58.00% <100.00%> (+1.80%) ⬆️
packages/editor-ui/src/constants.ts 99.68% <100.00%> (+<0.01%) ⬆️
...nodes-base/nodes/Google/Sheet/GoogleSheets.node.ts 0.00% <ø> (ø)
...es/Google/Sheet/v2/actions/sheet/read.operation.ts 0.00% <ø> (ø)
...odes/Google/Sheet/v2/actions/versionDescription.ts 0.00% <ø> (ø)
packages/workflow/src/Constants.ts 100.00% <100.00%> (ø)
packages/workflow/src/Interfaces.ts 77.77% <ø> (ø)
packages/editor-ui/src/components/Node.vue 71.67% <50.00%> (-0.03%) ⬇️
.../Google/Sheet/v2/actions/sheet/append.operation.ts 0.00% <0.00%> (ø)
...Sheet/v2/actions/sheet/appendOrUpdate.operation.ts 0.00% <0.00%> (ø)
... and 15 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link

cypress bot commented Oct 17, 2023

Passing run #2507 ↗︎

0 255 0 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project: n8n Commit: e2a85774e8
Status: Passed Duration: 09:08 💡
Started: Oct 17, 2023 3:31 PM Ended: Oct 17, 2023 3:40 PM

Review all test suite changes for PR #7357 ↗︎

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit d8531a5 into master Oct 17, 2023
56 checks passed
@michael-radency michael-radency deleted the node-711-google-sheets-tweaks branch October 17, 2023 15:41
@github-actions github-actions bot mentioned this pull request Oct 18, 2023
Merged
@netroy netroy changed the title fix(Google Sheets Node): Tweaks fix(Google Sheets Node): Update by row_number, restored 'Handling Extra Data Option', updated Cell Format default Oct 18, 2023
@netroy
Copy link
Member

netroy commented Oct 18, 2023 •
edited
Loading

Reminder: If the PR doesn't need to go in the changelog, please use no-changelog in the PR title. But, if it does need to go in the changelog, please use a title that corresponds to what the PR does.

netroy added a commit that referenced this pull request Oct 18, 2023
@github-actions @netroy
🚀 Release 1.12.0 (#7459)
ef58a23 
# [1.12.0](https://github.com/n8n-io/n8n/compare/n8n@1.11.0...n8n@1.12.0)
(2023-10-18)


### Bug Fixes

* **core:** Add check that queue is defined and remove cyclic dependency
([#7404](#7404))
([45f2ef3](45f2ef3))
* **core:** Do not throw when deleting workflows with executions without
binary-data ([#7411](#7411))
([2b6a15e](2b6a15e))
* **core:** Fix expression with paired item with multi-input node
([#7424](#7424))
([ec14141](ec14141))
* **core:** Fix ignoring crashed executions without event msgs
([#7368](#7368))
([2f4d91b](2f4d91b))
* **core:** Pg-promise de-initialization fix
([#7417](#7417))
([7703904](7703904))
* **core:** Prevent false stalled jobs in queue mode from displaying as
errored ([#7435](#7435))
([e01b9e5](e01b9e5))
* **core:** Prevent undefined issues when restoring binary data
([#7419](#7419))
([46977a2](46977a2))
* **editor:** Fix remote options fetching on every keystroke
([#7320](#7320))
([367255a](367255a))
* **editor:** Open only one tab with plans page
([#7377](#7377))
([c599006](c599006))
* **Google Sheets Node:** Update by row_number, restored 'Handling Extra
Data Option', updated Cell Format default
([#7357](#7357))
([d8531a5](d8531a5))
* **Ldap Node:** Fix issue with connections not closing correctly
([#7432](#7432))
([c3f0be8](c3f0be8))
* **Set Node:** Null should not throw an error
([#7416](#7416))
([e9b6ab0](e9b6ab0))
* **TheHive 5 Node:** Observable encoding in alert > create fix
([#7450](#7450))
([a2d2e3d](a2d2e3d))


### Features

* **core:** Make executions pruning interval configurable
([#7439](#7439))
([40707fa](40707fa))
* **Google Calendar Trigger Node:** Add support for cancelled events
([#7436](#7436))
([9d241a0](9d241a0))
* **HubSpot Trigger Node:** Add support for ticket related events
([#7156](#7156))
([57c6093](57c6093))
* **n8n Form Trigger Node:** New node
([#7130](#7130))
([3ddc176](3ddc176))
* **Spreadsheet File Node:** Improve CSV parsing
([#7448](#7448))
([79f23fb](79f23fb))

Co-authored-by: netroy <netroy@users.noreply.github.com>
@janober
Copy link
Member

janober commented Oct 18, 2023

Got released with n8n@1.12.0

elsmr pushed a commit that referenced this pull request Oct 19, 2023
@michael-radency @elsmr
fix(Google Sheets Node): Tweaks (#7357)
4c4da67 
Github issue / Community forum post (link here to close automatically):
elsmr pushed a commit that referenced this pull request Oct 19, 2023
@github-actions @netroy @elsmr
🚀 Release 1.12.0 (#7459)
e216ecc 
# [1.12.0](https://github.com/n8n-io/n8n/compare/n8n@1.11.0...n8n@1.12.0)
(2023-10-18)


### Bug Fixes

* **core:** Add check that queue is defined and remove cyclic dependency
([#7404](#7404))
([45f2ef3](45f2ef3))
* **core:** Do not throw when deleting workflows with executions without
binary-data ([#7411](#7411))
([2b6a15e](2b6a15e))
* **core:** Fix expression with paired item with multi-input node
([#7424](#7424))
([ec14141](ec14141))
* **core:** Fix ignoring crashed executions without event msgs
([#7368](#7368))
([2f4d91b](2f4d91b))
* **core:** Pg-promise de-initialization fix
([#7417](#7417))
([7703904](7703904))
* **core:** Prevent false stalled jobs in queue mode from displaying as
errored ([#7435](#7435))
([e01b9e5](e01b9e5))
* **core:** Prevent undefined issues when restoring binary data
([#7419](#7419))
([46977a2](46977a2))
* **editor:** Fix remote options fetching on every keystroke
([#7320](#7320))
([367255a](367255a))
* **editor:** Open only one tab with plans page
([#7377](#7377))
([c599006](c599006))
* **Google Sheets Node:** Update by row_number, restored 'Handling Extra
Data Option', updated Cell Format default
([#7357](#7357))
([d8531a5](d8531a5))
* **Ldap Node:** Fix issue with connections not closing correctly
([#7432](#7432))
([c3f0be8](c3f0be8))
* **Set Node:** Null should not throw an error
([#7416](#7416))
([e9b6ab0](e9b6ab0))
* **TheHive 5 Node:** Observable encoding in alert > create fix
([#7450](#7450))
([a2d2e3d](a2d2e3d))


### Features

* **core:** Make executions pruning interval configurable
([#7439](#7439))
([40707fa](40707fa))
* **Google Calendar Trigger Node:** Add support for cancelled events
([#7436](#7436))
([9d241a0](9d241a0))
* **HubSpot Trigger Node:** Add support for ticket related events
([#7156](#7156))
([57c6093](57c6093))
* **n8n Form Trigger Node:** New node
([#7130](#7130))
([3ddc176](3ddc176))
* **Spreadsheet File Node:** Improve CSV parsing
([#7448](#7448))
([79f23fb](79f23fb))

Co-authored-by: netroy <netroy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maspio maspio maspio approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/improvement New feature or request node/issue Issue with a node Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michael-radency @netroy @janober @maspio