refactor(core)!: Remove webhook deregistration at startup and shutdown #7515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Make sure to check off this list before asking for review. |
n8n-assistant
bot
added
core
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7515 +/- ##
==========================================
- Coverage 33.59% 33.59% -0.01%
==========================================
Files 3401 3401
Lines 207699 207719 +20
Branches 22467 22464 -3
==========================================
- Hits 69781 69775 -6
- Misses 136771 136797 +26
Partials 1147 1147
☔ View full report in Codecov by Sentry. |
ivov
changed the title
netroy
requested changes
Oct 26, 2023
netroy
previously approved these changes
Oct 26, 2023
|
|
||
| const removePromises = []; | ||
| if (!skipWebhookDeregistration) { | ||
| removePromises.push(this.activeWorkflowRunner.removeAll()); |
There was a problem hiding this comment.
we don't need to change it in this PR, but I think we should move activeWorkflowRunner.removeAll into a test utility, as it's only used in tests now.
2 flaky tests on run #2588 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Output
Screenshots
Video
|
|
18-user-management.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| User Management > should delete user and transfer their data |
Output
Screenshots
Video
|
|
Review all test suite changes for PR #7515 ↗︎
|
✅ All Cypress E2E specs passed |
|
✅ All Cypress E2E specs passed |
netroy
approved these changes
Oct 26, 2023
|
✅ All Cypress E2E specs passed |
ivov
added a commit
that referenced
this pull request
Oct 27, 2023
Removal missing from [original PR](#7515) after initial revert.
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/n8n/issue/PAY-932/deprecate-flag-to-skip-webhook-deregistration-on-shutdown