fix: Throw error when failing to save workflow history version #7706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
ivov
previously approved these changes
Nov 15, 2023
4 flaky tests on run #2882 ↗︎
Details:
|
||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Canvas Node Manipulation and Navigation > should add nodes and check execution success |
Screenshots
Video
|
|
6-code-node.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| ... > generate code button should have correct state & tooltips |
Screenshots
Video
|
|
28-resource-mapper.cy.ts • 2 flaky tests
| Test | Artifacts | |
|---|---|---|
| Resource Mapper > should correctly delete single field |
Screenshots
Video
|
|
| Resource Mapper > should correctly delete all fields |
Screenshots
Video
|
|
Review all test suite changes for PR #7706 ↗︎
|
✅ All Cypress E2E specs passed |
netroy
reviewed
Nov 16, 2023
|
I've implemented this PR to try and address an identified issue. I still like the changes here so I think it's worth merging both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue / Community forum post (link here to close automatically):