Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Include cypress TypeScript types in /cypress folder (no-changelog) #7746

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Nov 17, 2023

No description provided.

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Nov 17, 2023
Copy link

cypress bot commented Nov 17, 2023

4 flaky tests on run #2946 ↗︎

0 276 5 0 Flakiness 4

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Project: n8n Commit: 6b9c2d9e7a
Status: Passed Duration: 05:41 💡
Started: Nov 17, 2023 1:20 PM Ended: Nov 17, 2023 1:25 PM
Flakiness  6-code-node.cy.ts • 1 flaky test

View Output Video

Test Artifacts
... > generate code button should have correct state & tooltips Screenshots Video
Flakiness  28-resource-mapper.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Resource Mapper > should correctly delete single field Screenshots Video
Flakiness  26-resource-locator.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Resource Locator > should retrieve list options when other params throw errors Screenshots Video
Flakiness  20-workflow-executions.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Current Workflow Executions > should render executions tab correctly Screenshots Video

Review all test suite changes for PR #7746 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@elsmr elsmr merged commit c9f6ea1 into master Nov 20, 2023
58 of 59 checks passed
@elsmr elsmr deleted the cypress-tsconfig branch November 20, 2023 08:26
MiloradFilipovic added a commit that referenced this pull request Nov 20, 2023
* master: (27 commits)
  fix: Include cypress TypeScript types in /cypress folder (no-changelog) (#7746)
  refactor(core): Stop reporting to Sentry `NodeApiError` outside 500 range (no-changelog) (#7753)
  fix(core): Guard against node not found on cancelling test webhook (#7750)
  fix(JotForm Trigger Node): Fix iteration on form loader (#7751)
  refactor(core): Stop reporting to Sentry unknown cred on mapping (no-changelog) (#7752)
  feat(core): Coordinate manual workflow activation and deactivation in multi-main scenario (#7643)
  ci: Fix "Release: Create Pull Request" workflow
  fix(editor): Fix Admin panel icon in the sidebar for cloud deployments (no-changelog) (#7738)
  fix(editor): Remove `n8nHooksNext` flag (no-changelog) (#7733)
  fix(editor): Show v1 banner dismiss button if owner (#7722)
  fix(GitHub Node): Fix issue preventing file edits on branches (#7734)
  fix(core): Fix all dependency versions for backend packages (no-changelog) (#7745)
  refactor(core): Convert dynamic node-parameter routes to a decorated controller (no-changelog) (#7284)
  refactor: Stop reporting to Sentry Facebook multi-webhook error (no-changelog) (#7743)
  refactor(core): Stop reporting to Sentry unrecognized node errors (no-changelog) (#7728)
  fix(core): Account for non-ASCII chars in filename on binary data download (#7742)
  ci: Fix DB tests and Workflow tests (no-changelog) (#7741)
  refactor: Extract Invitation routes to InvitationController (no-changelog) (#7726)
  fix(editor): Handle permission edge cases (empty scopes) (#7723)
  ci: Skip the regularly failing tests in 2-credentials.cy.ts (no-changelog) (#7736)
  ...
MiloradFilipovic added a commit that referenced this pull request Nov 22, 2023
* master: (89 commits)
  feat(core): Make postgres pool-size configurable (no-changelog) (#7772)
  refactor(core): Include execution progress in save settings (no-changelog) (#7769)
  refactor: Upgrade to TypeScript 5.3 (no-changelog) (#7768)
  fix(editor): Only show push to git menu item to owners (#7766)
  fix(editor): Use project diagram icon for worker view (#7764)
  fix(Item Lists Node): Don't check same type in remove duplicates operation (#7678)
  fix(editor): Move workerview entry into settings menu (#7761)
  fix(core): Ensure failed executions are saved in queue mode (#7744)
  docs: Update docs links for data transformation functions and ifEmpty (#7758)
  feat(editor): Add node context menu (#7620)
  feat: Add Creator hub link to Templates page (#7721)
  fix: Include cypress TypeScript types in /cypress folder (no-changelog) (#7746)
  refactor(core): Stop reporting to Sentry `NodeApiError` outside 500 range (no-changelog) (#7753)
  fix(core): Guard against node not found on cancelling test webhook (#7750)
  fix(JotForm Trigger Node): Fix iteration on form loader (#7751)
  refactor(core): Stop reporting to Sentry unknown cred on mapping (no-changelog) (#7752)
  feat(core): Coordinate manual workflow activation and deactivation in multi-main scenario (#7643)
  ci: Fix "Release: Create Pull Request" workflow
  fix(editor): Fix Admin panel icon in the sidebar for cloud deployments (no-changelog) (#7738)
  fix(editor): Remove `n8nHooksNext` flag (no-changelog) (#7733)
  ...
@janober
Copy link
Member

janober commented Nov 22, 2023

Got released with n8n@1.18.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants