feat(core): Make postgres pool-size configurable (no-changelog) #7772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krynble
approved these changes
Nov 21, 2023
5 flaky tests on run #2973 ↗︎
Details:
|
||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Canvas Node Manipulation and Navigation > should add nodes and check execution success |
Screenshots
Video
|
|
12-canvas-actions.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Canvas Actions > should execute node |
Screenshots
Video
|
|
28-resource-mapper.cy.ts • 2 flaky tests
| Test | Artifacts | |
|---|---|---|
| Resource Mapper > should correctly delete single field |
Screenshots
Video
|
|
| Resource Mapper > should correctly delete all fields |
Screenshots
Video
|
|
20-workflow-executions.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Current Workflow Executions > should render executions tab correctly |
Screenshots
Video
|
|
Review all test suite changes for PR #7772 ↗︎
|
✅ All Cypress E2E specs passed |
n8n-assistant
bot
added
core
MiloradFilipovic
added a commit
that referenced
this pull request
Nov 22, 2023
* master: (89 commits) feat(core): Make postgres pool-size configurable (no-changelog) (#7772) refactor(core): Include execution progress in save settings (no-changelog) (#7769) refactor: Upgrade to TypeScript 5.3 (no-changelog) (#7768) fix(editor): Only show push to git menu item to owners (#7766) fix(editor): Use project diagram icon for worker view (#7764) fix(Item Lists Node): Don't check same type in remove duplicates operation (#7678) fix(editor): Move workerview entry into settings menu (#7761) fix(core): Ensure failed executions are saved in queue mode (#7744) docs: Update docs links for data transformation functions and ifEmpty (#7758) feat(editor): Add node context menu (#7620) feat: Add Creator hub link to Templates page (#7721) fix: Include cypress TypeScript types in /cypress folder (no-changelog) (#7746) refactor(core): Stop reporting to Sentry `NodeApiError` outside 500 range (no-changelog) (#7753) fix(core): Guard against node not found on cancelling test webhook (#7750) fix(JotForm Trigger Node): Fix iteration on form loader (#7751) refactor(core): Stop reporting to Sentry unknown cred on mapping (no-changelog) (#7752) feat(core): Coordinate manual workflow activation and deactivation in multi-main scenario (#7643) ci: Fix "Release: Create Pull Request" workflow fix(editor): Fix Admin panel icon in the sidebar for cloud deployments (no-changelog) (#7738) fix(editor): Remove `n8nHooksNext` flag (no-changelog) (#7733) ...
MiloradFilipovic
added a commit
that referenced
this pull request
Nov 22, 2023
* master: 🚀 Release 1.18.0 (#7780) fix(core): Pass correct node reference to NodeExecuteFunctions.getLoadOptionsFunctions (no-changelog) (#7779) docs: Add workflow template contribution to the contributing guide (#7777) fix(editor): Validate user info before submiting (#7608) feat(core): Make postgres pool-size configurable (no-changelog) (#7772) refactor(core): Include execution progress in save settings (no-changelog) (#7769) refactor: Upgrade to TypeScript 5.3 (no-changelog) (#7768) fix(editor): Only show push to git menu item to owners (#7766) fix(editor): Use project diagram icon for worker view (#7764) fix(Item Lists Node): Don't check same type in remove duplicates operation (#7678) fix(editor): Move workerview entry into settings menu (#7761) fix(core): Ensure failed executions are saved in queue mode (#7744) docs: Update docs links for data transformation functions and ifEmpty (#7758) feat(editor): Add node context menu (#7620)
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we upgrade typeorm in #5151, we switched from no pooling to a default pool-size of 10. This somehow significantly deteriorates the performance of queries when the application is under load.