Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Adjust starter node priority for manual executions with pinned activators #8386

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Jan 18, 2024

Story: https://linear.app/n8n/issue/PAY-1099

This PR adjusts starter node priority for manual executions with pinned activators, prioritizing n8n-nodes-base.webhook and ignoring n8n-nodes-base.respondToWebhook.

@netroy

This comment was marked as outdated.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jan 18, 2024
krynble
krynble previously approved these changes Jan 18, 2024
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Jan 18, 2024

Passing run #3831 ↗︎

0 336 5 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project: n8n Commit: f3fe46e468
Status: Passed Duration: 03:20 💡
Started: Jan 19, 2024 9:11 AM Ended: Jan 19, 2024 9:14 AM

Review all test suite changes for PR #8386 ↗︎

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

1 similar comment
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

✅ All Cypress E2E specs passed

@ivov ivov merged commit 749ac2b into master Jan 19, 2024
28 checks passed
@ivov ivov deleted the adjust-starter-node-priority-for-manual-executions-with-pinned-activators branch January 19, 2024 09:18
ivov added a commit that referenced this pull request Jan 22, 2024
@github-actions github-actions bot mentioned this pull request Jan 22, 2024
@janober
Copy link
Member

janober commented Jan 22, 2024

Got released with n8n@1.25.1

@github-actions github-actions bot mentioned this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants