Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Extract From File Node): Remove unimplemented xml operation (no-changelog) #8491

Closed
wants to merge 1 commit into from
Closed

fix(Extract From File Node): Remove unimplemented xml operation (no-changelog) #8491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions packages/nodes-base/nodes/Files/ExtractFromFile/ExtractFromFile.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,12 +79,6 @@ export class ExtractFromFile implements INodeType {
action: 'Extract from text file',
description: 'Extracts the content of a text file',
},
{
name: 'Extract From XML',
value: 'xml',
action: 'Extract from XLS',
description: 'Extracts the content of an XML file',
},
{
name: 'Extract From XLS',
value: 'xls',
Expand Down Expand Up @@ -121,7 +115,7 @@ export class ExtractFromFile implements INodeType {
returnData = await spreadsheet.execute.call(this, items, 'operation');
}

if (['binaryToPropery', 'fromJson', 'text', 'fromIcs', 'xml'].includes(operation)) {
if (['binaryToPropery', 'fromJson', 'text', 'fromIcs'].includes(operation)) {
returnData = await moveTo.execute.call(this, items, operation);
}

Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/Files/ExtractFromFile/actions/moveTo.operation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ export const properties: INodeProperties[] = [

const displayOptions = {
show: {
operation: ['binaryToPropery', 'fromJson', 'text', 'fromIcs', 'xml'],
operation: ['binaryToPropery', 'fromJson', 'text', 'fromIcs'],
},
};

Expand Down
Loading