Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Consistent tsconfig setup for backend packages and fix pnpm typecheck for composite packages (no-changelog) #9604

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented Jun 3, 2024

Extracted out of #9450, supersedes #9455

Review / Merge checklist

  • PR title and summary are descriptive

@netroy netroy requested a review from ivov June 3, 2024 15:49
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request labels Jun 3, 2024
Copy link

cypress bot commented Jun 5, 2024

2 flaky tests on run #5313 ↗︎

0 354 0 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n Commit: 059c15f317
Status: Passed Duration: 04:45 💡
Started: Jun 5, 2024 7:43 AM Ended: Jun 5, 2024 7:47 AM
Flakiness  5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
Flakiness  20-workflow-executions.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Current Workflow Executions > should auto load more items if there is space and auto scroll Test Replay Screenshots Video

Review all test suite changes for PR #9604 ↗︎

Copy link
Contributor

github-actions bot commented Jun 5, 2024

✅ All Cypress E2E specs passed

@netroy netroy merged commit 044607e into master Jun 5, 2024
28 checks passed
@netroy netroy deleted the start-enforcing-typechecking branch June 5, 2024 07:50
MiloradFilipovic added a commit that referenced this pull request Jun 5, 2024
* master:
  refactor(core): Move curl endpoint to its own controller (no-changelog) (#9605)
  refactor(core): Restore test for execution pagination in Public API (no-changelog) (#9621)
  ci: Consistent tsconfig setup for backend packages and fix pnpm typecheck for composite packages (no-changelog) (#9604)
@janober
Copy link
Member

janober commented Jun 5, 2024

Got released with n8n@1.45.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants