Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Error processing and output pane improvements (no-changelog) #9626

Merged

Conversation

michael-radency
Copy link
Contributor

Summary

fixes for errors not parsed correctly

Related tickets and issues

https://linear.app/n8n/issue/NODE-1285/error-display-in-output-pane-improvements

@michael-radency michael-radency added the n8n team Authored by the n8n team label Jun 5, 2024
@netroy netroy self-requested a review June 20, 2024 19:39
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM, but maybe @elsmr can also have a look since I'm not clear on the context here.

@netroy netroy requested a review from elsmr June 26, 2024 13:11
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Jun 26, 2024

2 flaky tests on run #5693 ↗︎

0 398 0 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project: n8n Commit: 0b8fdc92c4
Status: Passed Duration: 05:35 💡
Started: Jun 27, 2024 10:07 AM Ended: Jun 27, 2024 10:13 AM
Flakiness  e2e/5-ndv.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > Stop listening for trigger event from NDV Screenshots Video

Review all test suite changes for PR #9626 ↗︎

…error-display-in-output-pane-improvements
Copy link
Member

@elsmr elsmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit 4773aad into master Jun 27, 2024
26 checks passed
@michael-radency michael-radency deleted the node-1285-error-display-in-output-pane-improvements branch June 27, 2024 10:22
@janober
Copy link
Member

janober commented Jul 3, 2024

Got released with n8n@1.49.0

adrian-martinez-onestic pushed a commit to onesdata/n8n-fork that referenced this pull request Jul 8, 2024
…n-io#9626)

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants