-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Error processing and output pane improvements (no-changelog) #9626
fix: Error processing and output pane improvements (no-changelog) #9626
Conversation
…s, do not re-wrap NodeApiError
…error-display-in-output-pane-improvements
…error-display-in-output-pane-improvements
…anitizeUiMessage - make deep copy of request object
…error-display-in-output-pane-improvements
…error-display-in-output-pane-improvements
…error-display-in-output-pane-improvements
…error-display-in-output-pane-improvements
…play-in-output-pane-improvements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM, but maybe @elsmr can also have a look since I'm not clear on the context here.
|
2 flaky tests on run #5693 ↗︎
Details:
e2e/5-ndv.cy.ts • 2 flaky tests
Review all test suite changes for PR #9626 ↗︎ |
…error-display-in-output-pane-improvements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
✅ All Cypress E2E specs passed |
Got released with |
…n-io#9626) Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Summary
fixes for errors not parsed correctly
Related tickets and issues
https://linear.app/n8n/issue/NODE-1285/error-display-in-output-pane-improvements