refactor(editor): Migrate InlineNameEdit & InlineTextEdit components to Vue 3 syntax (no-changelog)
#9755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts to Vue 3 syntax Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
n8n-assistant
bot
added
n8n team
2 failed and 2 flaky tests on run #5599 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Execution > should execute workflow partially up to the node that has issues |
Test Replay
Screenshots
Video
|
|
20-workflow-executions.cy.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Current Workflow Executions > should error toast when server error message returned without stack trace |
Test Replay
Screenshots
Video
|
|
The first 5 failed specs are shown, see all 41 specs in Cypress Cloud.
10-undo-redo.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Undo/Redo > should undo/redo renaming node using NDV |
Test Replay
Screenshots
Video
|
|
5-ndv.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
Review all test suite changes for PR #9755 ↗︎
netroy
approved these changes
Jun 19, 2024
|
✅ All Cypress E2E specs passed |
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jun 20, 2024
…nts to Vue 3 syntax (no-changelog) (n8n-io#9755) Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jun 20, 2024
…nts to Vue 3 syntax (no-changelog) (n8n-io#9755) Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
|
Got released with |
1 similar comment
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)