Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Upgrade oclif (no-changelog) #9881

Merged
merged 1 commit into from
Jun 27, 2024
Merged

feat(core): Upgrade oclif (no-changelog) #9881

merged 1 commit into from
Jun 27, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented Jun 27, 2024

Summary

oclif v4 trimmed down a lot of their dependencies, and that helps reduce our baseline memory by a tiny bit.

Review / Merge checklist

  • PR title and summary are descriptive

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jun 27, 2024
@ivov ivov self-assigned this Jun 27, 2024
ivov
ivov approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continues to work + breaking changes look good

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress Cypress
Copy link

cypress bot commented Jun 27, 2024 •
edited
Loading

7 flaky tests on run #5700 ↗︎

0 398 0 0 Flakiness 7

Details:

🌳 bug-perf 🖥️ browsers:node18.12.0-chrome107 🤖 schedule 🗃️ e2e/*
Project: n8n Commit: e6ec07d1ee
Status: Passed Duration: 05:46 💡
Started: Jun 27, 2024 4:03 PM Ended: Jun 27, 2024 4:09 PM
Flakiness  5-ndv.cy.ts • 3 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > should retrieve remote options when non-required params throw errors Screenshots Video
NDV > Stop listening for trigger event from NDV Screenshots Video
Flakiness  10-undo-redo.cy.ts • 3 flaky tests

View Output Video

Test Artifacts
Undo/Redo > should undo/redo adding nodes Test Replay Screenshots Video
Undo/Redo > should undo/redo adding connected nodes Test Replay Screenshots Video
Undo/Redo > should undo/redo renaming node using NDV Test Replay Screenshots Video
Flakiness  30-editor-after-route-changes.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Editor actions should work > after saving a new workflow Test Replay Screenshots Video

Review all test suite changes for PR #9881 ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit 2885091 into master Jun 27, 2024
27 checks passed
@netroy netroy deleted the upgrade-oclif branch June 27, 2024 15:26
@janober
Copy link
Member

janober commented Jul 3, 2024

Got released with n8n@1.49.0

adrian-martinez-onestic pushed a commit to onesdata/n8n-fork that referenced this pull request Jul 8, 2024
@netroy @adrian-martinez-onestic
feat(core): Upgrade oclif (no-changelog) (n8n-io#9881)
e808a2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivov ivov ivov approved these changes

Assignees

@ivov ivov

Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@netroy @janober @ivov