fix(core): Fix worker logs relay #9919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivov
added
the
release/backport
n8n-assistant
bot
added
core
2 flaky tests on run #5751 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
24-ndv-paired-item.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9919 ↗︎
|
✅ All Cypress E2E specs passed |
cstuncsik
pushed a commit
that referenced
this pull request
Jul 3, 2024
Merged
ivov
added a commit
that referenced
this pull request
Jul 3, 2024
Merged
|
Got released with |
Merged
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Recently
EventBuswas decoupled fromInternalHooksviaAuditEventRelay, which listens for events and forwards them to be logged.AuditEventRelayworks in main but was missing initialization in the worker.Related Linear tickets, Github issues, and Community forum posts
https://n8nio.slack.com/archives/C069YF49G8Y/p1719923928941329
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)