Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: 开启 auth 造成卡住，日志不再输出，可能服务也会下线！ #161

Closed
CherishCai opened this issue May 17, 2023 · 3 comments · Fixed by #162
Closed

Bug: 开启 auth 造成卡住，日志不再输出，可能服务也会下线！ #161

CherishCai opened this issue May 17, 2023 · 3 comments · Fixed by #162
Assignees
@CherishCai
Labels
bug Something isn't working
Milestone
0.3.0

Comments

@CherishCai
Copy link
Collaborator

CherishCai commented May 17, 2023 •
edited
Loading

解决方案

  • 将会在 0.3.x 做 Break Change，调整插件 api 为 async

复现手段

默认 auth 为 (let delay_sec = login_response.token_ttl / 10;) 30min 复现卡住；
可以调整为 let delay_sec = login_response.token_ttl / 100; 3min 复现

现象如下

  1. 【新逻辑】卡在 receiver.recv()
    image

  2. 【旧逻辑】卡在 futures::executor::block_on(future)
    image
@CherishCai CherishCai added the bug Something isn't working label May 17, 2023
@CherishCai CherishCai added this to the 0.3.0 milestone May 17, 2023
@CherishCai CherishCai self-assigned this May 17, 2023
@CherishCai
Copy link
Collaborator Author

@gy0801151351 请关注

@gy0801151351 gy0801151351 mentioned this issue May 17, 2023
Merged
@gy0801151351
Copy link
Contributor

查看了代码, 发现是合并了一段中间代码. 这个地方我改了两次, 第一次是使用channel, 第二次是使用executor.

CherishCai added a commit that referenced this issue May 17, 2023
@CherishCai
Change: Break Change api of auth plugin, support async fn. #161
7b6294b
CherishCai added a commit that referenced this issue May 17, 2023
@CherishCai
Change: Break Change api of auth plugin, support async fn. #161
1b1a23b
@CherishCai CherishCai mentioned this issue May 17, 2023
Merged
@CherishCai
Copy link
Collaborator Author

It seems like tokio-rs/tokio#4730

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CherishCai CherishCai

Labels
bug Something isn't working
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

Change: Break Change api of auth plugin, support async fn. nacos-group/nacos-sdk-rust
2 participants
@gy0801151351 @CherishCai