Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Break Change api of auth plugin, support async fn. #162

Merged
merged 1 commit into from
May 17, 2023

Conversation

CherishCai
Copy link
Collaborator

@CherishCai CherishCai commented May 17, 2023

Fix #161

@CherishCai CherishCai added this to the 0.3.0 milestone May 17, 2023
@CherishCai CherishCai requested a review from onewe May 17, 2023 14:36
@CherishCai CherishCai self-assigned this May 17, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 2.08% and project coverage change: +0.10 🎉

Comparison is base (9f18bf0) 8.84% compared to head (1b1a23b) 8.95%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #162      +/-   ##
========================================
+ Coverage   8.84%   8.95%   +0.10%     
========================================
  Files         49      49              
  Lines       2780    2737      -43     
========================================
- Hits         246     245       -1     
+ Misses      2534    2492      -42     
Impacted Files Coverage Δ
src/api/plugin/auth/auth_by_http.rs 0.00% <0.00%> (ø)
src/api/plugin/auth/mod.rs 0.00% <0.00%> (ø)
src/common/remote/grpc/layers/auth.rs 0.00% <0.00%> (ø)
src/common/remote/grpc/nacos_grpc_connection.rs 0.00% <0.00%> (ø)
src/common/remote/grpc/tonic.rs 0.00% <0.00%> (ø)
src/config/worker.rs 0.00% <0.00%> (ø)
src/naming/mod.rs 0.00% <0.00%> (ø)
src/naming/redo/mod.rs 0.00% <0.00%> (ø)
src/common/cache/mod.rs 84.80% <100.00%> (-0.13%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@CherishCai CherishCai merged commit f90f76e into main May 17, 2023
@CherishCai CherishCai deleted the change_auth_plugin_async_fn_issue_161 branch May 17, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: 开启 auth 造成卡住,日志不再输出,可能服务也会下线!
2 participants