Delete/Unset Transactions Category #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kang @dels07, thank you for this PR, I see our Travis still fails here, i will make fix this first before continuing review this PR. |
|
Kang @dels07, i am sorry for very late on reviewing this PR. I will commit some improvement to this PR, then merge it. Thanks. |
Checkbox fields are only processed by form request if they are checked. If they are not checked, form request attribute do not include them. So, in this commit, we just want to check whether the delete_transactions field are exists or not.
|
Thanks kang @dels07. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add feature to delete/unset transactions related to category