-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use Eloquent::when() – no more if-else’s #44
Conversation
@RoisNewVersion, thanks for the PR. Could you please fix your code to pass the Style-CI? I see you change a lot of string concatenations. |
Sorry for interrupt, I used to have php formater ext in my VSCode, I just hit Shift+Alt+F that automatically reformat the code. |
@RoisNewVersion, you can turn off your auto format from your VSCode, then just change the lines that you want to change. If we passed the style-ci, I will start reviewing your changes. |
Okay, I did it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RoisNewVersion, I see some short variable names, those variable names are not very readable. I am suggesting some changes to this PR.
Ahh.. I see, my silly mistake. Thanks for suggestion Co-Authored-By: Nafies Luthfi <nafiesl@gmail.com>
Co-Authored-By: Nafies Luthfi <nafiesl@gmail.com>
Co-Authored-By: Nafies Luthfi <nafiesl@gmail.com>
Co-Authored-By: Nafies Luthfi <nafiesl@gmail.com>
Co-Authored-By: Nafies Luthfi <nafiesl@gmail.com>
Co-Authored-By: Nafies Luthfi <nafiesl@gmail.com>
Co-Authored-By: Nafies Luthfi <nafiesl@gmail.com>
Co-Authored-By: Nafies Luthfi <nafiesl@gmail.com>
Co-Authored-By: Nafies Luthfi <nafiesl@gmail.com>
Co-Authored-By: Nafies Luthfi <nafiesl@gmail.com>
Co-Authored-By: Nafies Luthfi <nafiesl@gmail.com>
Co-Authored-By: Nafies Luthfi <nafiesl@gmail.com>
@RoisNewVersion, why are you closing this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I am merging this PR @RoisNewVersion. Thanks.
use Eloquent::when() method instead of using if else statement.