Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Composer Dependency Issue #52

Merged
merged 4 commits into from
Jun 15, 2020
Merged

Fixing Composer Dependency Issue #52

merged 4 commits into from
Jun 15, 2020

Conversation

nafiesl
Copy link
Owner

@nafiesl nafiesl commented Jun 7, 2020

In this PR, we are fixing dependency issue which was reported on #51 @Maikuolan. If someone can help to verify this PR, it would be very helpful.

How to Test

  1. Install this project (installation steps).
  2. git fetch origin
  3. git checkout fixing_dependency_issue
  4. php artisan passport:install
  5. On .env file, add these 2 variables:
PASSPORT_CLIENT_ID=2 # value from DB: oauth_clients.id
PASSPORT_CLIENT_SECRET=n8e2mBNiHllxxxxx # value from DB: oauth_clients.secret
  1. Register new account
  2. Use this curl sample to get an access_token:
curl -X POST 'http://dompet.test/api/auth/login' \
-H 'Accept: application/json' \
-H 'Content-Type: text/plain' \
-d '{
    "email": "your_username@mail.com",
    "password": "super_secret"
}'
  1. Expected response:
{
    "token_type": "Bearer",
    "expires_in": 31536000,
    "access_token": "eyJ0eXAiOiJ...{long token}",
    "refresh_token": "def502008f7a...{long token}"
}

If we have no issue up to point 8, then this PR should resolve #51.

Remove laravel/passport to ^7.3
Install laravel/passport to ^8.2
Remove laravel/tinker ^1.0
Install laravel/tinker ^2.4
@nafiesl nafiesl merged commit c4fd0b2 into master Jun 15, 2020
@nafiesl nafiesl deleted the fixing_dependency_issue branch June 15, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some deprecation/abandonment warnings when installing with Composer
1 participant