Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #55 and add feature deploy with Github Actions #56

Merged
merged 10 commits into from
Sep 20, 2020
Merged

Fix issue #55 and add feature deploy with Github Actions #56

merged 10 commits into from
Sep 20, 2020

Conversation

kresnasatya
Copy link
Contributor

Halo mas @nafiesl, ini adalah PR untuk memperbaiki isu #55 dan fitur tambahan untuk deploy project Laravel dengan Github Actions. Untuk panduan cara deploy bisa dibaca di blog saya: Deploy Laravel Project dengan Github Actions. Makasih. 🙏

@kresnasatya
Copy link
Contributor Author

Oh iya, di Github Actions ini juga ada fitur untuk melakukan integration testing. ;)

@kresnasatya
Copy link
Contributor Author

Halo mas @nafiesl, ini ada style CI yang saya bingung bagaimana cara perbaikinya. Mohon dibantu ya mas. 🙏

@kresnasatya kresnasatya changed the title Fix issue #55 and add deploy with Github Actions Fix issue #55 and add feature deploy with Github Actions Sep 6, 2020
@kresnasatya
Copy link
Contributor Author

Halo mas @nafiesl, ini ada style CI yang saya bingung bagaimana cara perbaikinya. Mohon dibantu ya mas. 🙏

Ops, ngga jadi mas. Sudah berhasil saya perbaiki. Tolong dibantu cek PR saya ya mas bila ada waktu luang. Trima kasih. 🙏

Copy link
Owner

@nafiesl nafiesl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mantap ni, makasih mas @satyakresna.

@nafiesl nafiesl merged commit f5af269 into nafiesl:master Sep 20, 2020
@kresnasatya
Copy link
Contributor Author

Sama" mas. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants