Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Nager.Date to handle county CH-NE holidays #1

Closed
wants to merge 14 commits into from

Conversation

brizuelal
Copy link

No description provided.

@tinohager
Copy link
Member

Hi brizuelal
You have commit a lot of changes to my project. I have public holiday for CH-NE in my project if the informations wrong?

Copy link
Member

@tinohager tinohager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why you add in the enum of the Country CH-GR, CH-TI ?

@brizuelal
Copy link
Author

brizuelal commented Dec 12, 2016 via email

@brizuelal
Copy link
Author

brizuelal commented Dec 12, 2016 via email

@tinohager
Copy link
Member

A lot of files are edited also Nager.Date.nuspec with iconUrl and a new authors..., the pull request is very extensive and not easy to handle.

In the file .vs/config/applicationhost.config i have your home directory of your Server i think i must change the gitignore file first :)

@brizuelal
Copy link
Author

brizuelal commented Dec 13, 2016

Sorry for not doing things properly, I still have a lot to learn about Git, this is my first pull-request so feel free merge or skip changes if you are not interested in.

I also updated Enum ECountry to remove worng values added by mistake. The library is now 100% business compliant for county CH-NE.

@tinohager
Copy link
Member

i add the next days all your changes to my Project and publish a new package on nuget

@brizuelal
Copy link
Author

brizuelal commented Dec 15, 2016 via email

@tinohager
Copy link
Member

in the pull request the newYearDate is DateTime(year, 12, 25) this is wrong correct?

@tinohager
Copy link
Member

i think i have add all new logic can you check the public Holidays for switzerland?

@tinohager tinohager closed this Dec 21, 2016
@tinohager
Copy link
Member

new nuget package is deployed 1.0.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants