[pull] master from darktable-org:master #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
add popup menu entries to copy tags to clipboard
Translations update: en@truecase and Ukrainian
Fix possible issue reported: 248,2990 [_import_enum_callback] unable to create iterator, error: L’opération a été annulée (darktable:1423563): GLib-GIO-CRITICAL **: 09:29:54.005: g_file_enumerator_next_files_async: assertion 'G_IS_FILE_ENUMERATOR (enumerator)' failed
Translations update: en@truecase and Ukrainian
The module colorpickers in blend mode can get the picker data from input & output after full conversion to blend_cst colorspace. As we do this anyway it's faster and easier to implement than explicit conversion while reading pickerdata.
- avoid more superfluous casts - avoid "struct" in function parameters if there is an existing typedef for that struct as it doesn't improve safety - code style; formatting and leading underscore for static functions - added many const - replace a bool by gboolean - slightly improved logs for rendered forms - remove dt_pixelpipe_name() as being unused - dt_dev_pixelpipe_type_to_str() takes the correct dt_dev_pixelpipe_type_t instead of an int
Use the dt_opencl_enqueue_kernel_1d_args() OpenCL kernel calling variants where appropriate and change the kernel parameters accordingly. Fixed an OpenCL memory allocation check returning CL_SUCCESS in case of an error. Removed some superfluous "struct" in function parameters and some redundant casting.
Bump module version and make sure we pass FALSE for compatibility after any of the module parameter sliders has been used. So we keep compatibility with old edits but continue with the improved algorithm automatically.
update to recent pot file + consolidation of terminology in translation: Luminance: Physical light intensity Lightness: Perceived brightness or brightness value
Fix dehazing module
As for non grouped image, the border to preserve from the local copy corner flag is 0.07em.
Ensure Darktable is capitalized.
Translations update: en@truecase and Ukrainian
…sion the file has
This is only true for RAW and not for non-RAW so confusing.
At the same time fix default IOP order which could be for RAW instead of a JPG. We now check in DB the flags for DT_IMAGE_LDR.
* po/iop-order-3.1: Make code cleaner avoiding maintenance later. check_duplicate_iop_order: Fix to avoid generating identical iop-order. Introduce also a v3.1 iop order for JPG. Remove "default" from preset label. Minor reformatting. Further code simplification by introducing _iop_order_tables. Introduce new iop-order v3.1 where finalscale is before colorout. Minor code reformatting. iop_order: Code refactoring.
1. In dt_print_pipe() we always log the iop_order if a module is provided. While being here some additional safety string modifications 2. Removed specific iop_order logging where it's now covered by dt_print_pipe() leading to less code. 3. modify iop_order checks to int where correct. 4. minor mods while checking this
Wrong kernel args for `rawprepare_4f()` lead to CL code not working and forcing a fallback to CPU code for sraw files. Instead of fiddling with arg list just added two dummy pars for the kernel function. Some formatting to code style while checking this.
Translations update: en@truecase and Ukrainian
[imageio] PNG loader maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )