-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrering til urfave/cli #209
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Litt overkill med en for validering og en for output.
Manuelt testet følgende:
Gjenstår å teste aiven og postgres. |
3 tasks
Her kan ting feile senere i prosessen fordi man kan ha kjørt '--update-adc' som har gått ut på tid, eller for en annen konto.
Og da er alt testet, mangler å sikre #67 ikke skjer på alle kommandoen til Postgres, da dette feiler ganske langt nede i stacken, så får ikke lagd en catch all. |
#yolo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Denne PR-en bytter fra spf13/cobra og viper til urfave/cli. Det er ikke gjort store endringer utenom å bytte bibliotek. Litt forenkling av kubeconfig da https://github.com/nais/narcos har tatt over behovet for
nais naas
."Modellen" er også blitt endret, nå ligger alt som kun har med cli-commands under
./cmd
, mens koden som gjør ting ligger under./pkg
Jeg mener dette gjør koden enklere å vedlikeholde og teste. Pluss det gir oss muligheten til å gjenbruke ting på tvers av nais/narc ved behov (som ved kubeconfig-generering).fixes: #202