This repository has been archived by the owner on Mar 14, 2024. It is now read-only.
add: regex to check valid key for k8s and multiline envs #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ybelMekk
changed the title
ybelMekk
changed the title
ybelMekk
changed the title
|
Probably a more elegant solution to the problem 🤙 : #3 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the documentation from kubernetes you can read: https://v1-18.docs.kubernetes.io/docs/concepts/configuration/secret/#creating-a-secret-manually
The keys of data and stringData must consist of alphanumeric characters, '-', '_' or '.'.I think it could be a good to force this so that developers dont add stuff to their secret config not compatible with k8s.
But im not sure the regex is correct according to the k8s spec for accepted values
edit:
Added ability for multiline envs. delimiter&&can be replaced with something more elegant/right?edit 2:
A better approach is to use
\backslash for separate env. vars?