This repository has been archived by the owner on Mar 14, 2024. It is now read-only.
Replace ResourceManager with k8s namespace list #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can select namespaces from k8s because all team-namespaces are annotated with their corresponding google project-id. This will fix a bug with teams that have long names, where the project-id is cropped to it is impossible to guess the namespace (like we did previously)
tronghn
reviewed
Jul 19, 2021
tronghn
reviewed
Jul 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can select namespaces from k8s because all team-namespaces are
annotated with their corresponding google project-id.
This will fix a bug with teams that have long names, where the
project-id is cropped to it is impossible to guess the namespace (like
we did previously)