kafka/topic: add segmentHours and maxMessageBytes to configurations #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sechmann
approved these changes
Oct 18, 2022
tronghn
force-pushed
the
kafka-topic-config-galore
branch
from
e54d772
to
c2a1f1e
Compare
tronghn
force-pushed
the
kafka-topic-config-galore
branch
from
c2a1f1e
to
53be281
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/nais/features/issues/7.
Maximum and minimum values are somewhat arbitrarily chosen, though:
segmentHours(instead ofsegmentMs) should never be so small so that it can spawn a gazillion segments and take down the brokers due to a large amount of open files and memory usage, so we've set a value of 1 hour as a reasonble minimum.maxMessageBytesshould ideally never be increased beyond the defaults, though some users deem it necessary in certain cases. We've set the maximum value to 5 mebibytes for now, though we should strongly recommend using other techonologies or patterns (e.g. claim-check) if our users keep asking to increase this value in the future.